Skip to content

PM-39082: Feat: Do not show accessibility disclosure at app startup for Fdroid#7064

Merged
david-livefront merged 1 commit into
mainfrom
PM-39082-accessibility-disclosure-fdroid
Jun 16, 2026
Merged

PM-39082: Feat: Do not show accessibility disclosure at app startup for Fdroid#7064
david-livefront merged 1 commit into
mainfrom
PM-39082-accessibility-disclosure-fdroid

Conversation

@david-livefront

@david-livefront david-livefront commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-39082

📔 Objective

This PR updates the accessibility disclosure to only be displayed on app-startup when in standard releases and not in the Fdroid releases.

@david-livefront david-livefront requested a review from a team as a code owner June 15, 2026 19:07
@david-livefront david-livefront added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 15, 2026
@github-actions github-actions Bot added app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development labels Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed the change that suppresses the accessibility disclosure at app startup for F-Droid builds by OR-ing buildInfoManager.isFdroid into hasShownAccessibilityDisclaimerFlow. Confirmed the new BuildInfoManager dependency is wired symmetrically through PlatformRepositoryModule, and that both the .map transform and the stateIn initialValue were updated identically. Verified operator precedence is correct (?: binds tighter than ||, so the expression parses as isFdroid || (it ?: false)) and that the downstream consumer OverlayNavViewModel uses filterNot { it }, correctly skipping the disclosure when the flow emits true. Added tests cover both the F-Droid and non-F-Droid paths.

No findings.

@david-livefront david-livefront force-pushed the PM-39082-accessibility-disclosure-fdroid branch from 4127b94 to 2cb283c Compare June 15, 2026 19:19

@aj-rosado aj-rosado left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-livefront

Copy link
Copy Markdown
Collaborator Author

Thanks @aj-rosado

@david-livefront david-livefront added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit afab585 Jun 16, 2026
25 checks passed
@david-livefront david-livefront deleted the PM-39082-accessibility-disclosure-fdroid branch June 16, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow app:password-manager Bitwarden Password Manager app context t:feature Change Type - Feature Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants