[PM-37816] Remove check for new tab (#492)

* Remove check for new tab
* fix button locator
* remove unnecessary step

---------

Co-authored-by: ✨ Audrey ✨ <ajensen@bitwarden.com>

Author: trmartin4

benchmarks/fixtures.benchmark.ts

@@ -8,19 +8,14 @@ import {
 } from "@playwright/test";
 import { configDotenv } from "dotenv";
 
-import {
-  debugIsActive,
-  vaultEmail,
-  vaultPassword,
-  vaultHostURL,
-} from "../constants";
+import { vaultEmail, vaultPassword, vaultHostURL } from "../constants";
 import { PerfCapture } from "../abstractions";
 import {
-  closeWelcomePage,
   fetchFeatureFlags,
   type FeatureFlags,
   getBackgroundPage,
   loginToVault,
+  obtainTestPage,
   prepareEnvironment,
   readManifestVersion,
   submitEnvironment,
@@ -87,16 +82,7 @@ export function createBenchmarkTest(
       await use(extensionId);
     },
     extensionSetup: async ({ context, extensionId }, use) => {
-      let testPage: Page;
-
-      await test.step("Close the extension welcome page when it pops up", async () => {
-        testPage = await closeWelcomePage(
-          context,
-          !debugIsActive &&
-            process.env.HEADLESS !== "true" &&
-            process.env.CI === "true",
-        );
-      });
+      const testPage: Page = await obtainTestPage(context);
 
       await test.step("Configure the environment", async () => {
         if (vaultHostURL) {

fixtures/extension-setup.ts

@@ -6,21 +6,12 @@ import { defaultGotoOptions, defaultWaitForOptions } from "../constants";
 
 export type FeatureFlags = { [key: string]: boolean };
 
-export async function closeWelcomePage(
-  context: BrowserContext,
-  // Wait for the extension to open the welcome page before continuing
-  // (only relevant when using prod or build artifacts in CI)
-  shouldWaitForWelcomePopup: boolean,
-): Promise<Page> {
-  if (shouldWaitForWelcomePopup) {
-    await context.waitForEvent("page");
-  }
-
-  const contextPages = await context.pages();
+export async function obtainTestPage(context: BrowserContext): Promise<Page> {
+  const contextPages = context.pages();
 
   // close all but the first tab
   await Promise.all(
-    contextPages.slice(1).map((contextPage) => contextPage.close()),
+    contextPages.slice(1).map((contextPage: Page) => contextPage.close()),
   );
 
   return contextPages[0];
@@ -65,7 +56,7 @@ export async function prepareEnvironment(
 }
 
 export async function submitEnvironment(testPage: Page): Promise<void> {
-  await testPage.click("bit-dialog button[type='submit']");
+  await testPage.click("[bit-dialog] button[type='submit']");
 }
 
 export async function loginToVault(

tests/fixtures.browser.ts

@@ -10,18 +10,17 @@ import {
 import { configDotenv } from "dotenv";
 
 import {
-  debugIsActive,
   screenshotsOutput,
   vaultEmail,
   vaultPassword,
   vaultHostURL,
 } from "../constants";
 import {
-  closeWelcomePage,
   fetchFeatureFlags,
   type FeatureFlags,
   getBackgroundPage,
   loginToVault,
+  obtainTestPage,
   prepareEnvironment,
   readManifestVersion,
   submitEnvironment,
@@ -97,16 +96,7 @@ export const test = base.extend<{
     await use(extensionId);
   },
   extensionSetup: async ({ context, extensionId, testOutputPath }, use) => {
-    let testPage: Page;
-
-    await test.step("Close the extension welcome page when it pops up", async () => {
-      testPage = await closeWelcomePage(
-        context,
-        !debugIsActive &&
-          process.env.HEADLESS !== "true" &&
-          process.env.CI === "true",
-      );
-    });
+    const testPage: Page = await obtainTestPage(context);
 
     await test.step("Configure the environment", async () => {
       if (vaultHostURL) {