Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed a test-infrastructure PR that bumps the self-host Code Review DetailsNo blocking findings. Notes from analysis (no action required):
Dependency Changes
|
3504a90 to
9badcc3
Compare
51bcb12 to
8a82bb8
Compare
7f2a97c to
eeedf0e
Compare
|
This PR addresses a shared root cause in bitwarden/clients#21431 |
| env_file: | ||
| - .env | ||
| image: ghcr.io/bitwarden/lite:2026.6.0 | ||
| image: ghcr.io/bitwarden/lite@sha256:01181904fd02020dbc4d0598dd31a153b3784abd8a4d3ac9099fc1a939a58e6e # 2026.6.1 |
There was a problem hiding this comment.
hash pinning since tagged images are not immutable; as things currently stand, this may mean targeted images go away unceremoniously if this falls out of date
There was a problem hiding this comment.
meant to ensure renovate keeps the images up-to-date on the basis of their hash, and not tag
| - name: Wait for admin DB migrations to complete | ||
| run: | | ||
| echo "Waiting for admin DB migrations..." | ||
| timeout 120 sh -c ' | ||
| until docker compose exec -T bitwarden sh -c "grep -q \"Migration successful\" /etc/bitwarden/logs/admin-*.log 2>/dev/null"; do | ||
| sleep 2 | ||
| done | ||
| ' | ||
| echo "Migrations complete." |
There was a problem hiding this comment.
Server returns a success signal before migrations have finished. We previously solved this by retrying account creation over and over; that's still in, but now we wait for a more authoritative success signal. This remains unaddressed for local runs.
audreyality
left a comment
There was a problem hiding this comment.
♻️ This PR is taking on a pile of tech debt. I recommend we track that somewhere.
💭 It's very clever to patch node-fetch to work around the premature close.
🎟️ Tracking
PM-39586
Summary
There is a known issue with node-fetch. I fixed it in BIT's shell script for account creation by dropping cross-fetch and using the native node fetch, but the cipher seeding script still fails because it uses the CLI API, and the CLI bundles node-fetch
2.7.0: https://github.com/bitwarden/clients/blob/main/apps/cli/package.json#L84But, that's been pinned there for quite some time, and this bad interaction is recent. (a self-host image rewrite happened some time between
Jun 25, 4:53 AM EDT(last good BIT run with2026.6.0) andJun 25, 5:05 AM EDT(the first failure with this error on the rewritten2026.6.0image).Because
2026.6.0was working, and then broke when2026.6.1was tagged, I'm presuming the breaking change came with2026.6.1and not2026.6.0I was able to get BIT working again by ad-hoc patching
node-fetchbundled with the CLI in the test workflows, but local usage will continue to be bugged until addressed either by the server or CLI client