Skip to content

[PM-36230] Update project default config for better out-of-the-box usage#484

Merged
jprusik merged 6 commits into
mainfrom
pm-36230
May 6, 2026
Merged

[PM-36230] Update project default config for better out-of-the-box usage#484
jprusik merged 6 commits into
mainfrom
pm-36230

Conversation

@jprusik

@jprusik jprusik commented May 1, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-36230

📔 Objective

Update BIT to work locally by default; copy example .env over to local .env then populate using the setup scripts. Devs only have to run the setup script and follow the prompts.

@jprusik jprusik self-assigned this May 1, 2026
@jprusik jprusik marked this pull request as ready for review May 1, 2026 22:09
@jprusik jprusik requested a review from a team as a code owner May 1, 2026 22:09
@jprusik jprusik requested a review from dan-livefront May 1, 2026 22:09
@jprusik jprusik added the ai-review-vnext Request a Claude code review using the vNext workflow label May 1, 2026
Comment thread .env.example Outdated
Comment thread scripts/first-time-setup.sh
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR makes BIT work locally out-of-the-box by populating .env.example with sensible defaults, adding an automatic .env bootstrap step plus npm/docker compose prerequisite checks to first-time-setup.sh, and extracting setup:extension into a dedicated scripts/setup-extension.sh script. Both scripts now perform a graceful nvm install when nvm is detected. The README is updated to reflect the streamlined workflow and the move from the self-host Unified image reference to the Bitwarden Lite image.

Code Review Details

No blocking findings. The shell changes follow existing conventions (set -e, BASH_SOURCE-relative project root, graceful nvm fallbacks with || echo so set -e does not abort), and the .env.example defaults align with the Docker Compose configuration: BW_DOMAIN=127.0.0.1 matches the SSL cert SAN and the lite image reference matches the README link.

The two existing reviewer threads have been addressed:

  • .env.example placeholder password concern — fixed in 064d0e7 (default password no longer contains an email-shaped value).
  • first-time-setup.sh ordering of nvm install vs setup:ssl — resolved; generate-certs.sh does not require Node.

@jprusik jprusik requested a review from dan-livefront May 4, 2026 22:01
dan-livefront
dan-livefront previously approved these changes May 5, 2026
@jprusik jprusik merged commit a662548 into main May 6, 2026
19 checks passed
@jprusik jprusik deleted the pm-36230 branch May 6, 2026 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants