add closed shadow dom test#488
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds a new test scenario for autofill into inputs inside closed shadow DOMs at Code Review DetailsNo issues found. The change is well-scoped, internally consistent ( |
| TestNames.NewCredentialsNotification, | ||
| TestNames.PasswordUpdateNotification, |
There was a problem hiding this comment.
Playwright can still use navigational keyboard controls (Tab, Space, Enter) in order to navigate into an inline menu and execute a presumed selection (followed by a form submit via Enter). I have a PoC kicking around somewhere, I'll see if I can find it...
There was a problem hiding this comment.
The issue here isn't navigating the overlay. It's navigating into the username/password boxes in the first place. Keyboard controls can still work for that; what I wonder about is whether it's too brittle for the test case, since it depends on the tab order of the page's controls.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-35399
📔 Objective
Introduce a test that autofills inputs in closed shadow DOMs.
This test only runs the first Autofill scenario because the field within the shadow root cannot be focused by Playwright.