[PM-37816] Remove check for new tab#492
Merged
Merged
Conversation
trmartin4
changed the title
jprusik
reviewed
May 20, 2026
| process.env.CI === "true", | ||
| ); | ||
| await test.step("Obtain the test page", async () => { | ||
| testPage = await obtainTestPage(context); |
Collaborator
There was a problem hiding this comment.
non-blocking nit; this line can just go in at the start of the "Configure the environment" test step, but this is functional as well
jprusik
reviewed
May 20, 2026
| @@ -89,13 +88,8 @@ export function createBenchmarkTest( | |||
| extensionSetup: async ({ context, extensionId }, use) => { | |||
| let testPage: Page; | |||
Collaborator
There was a problem hiding this comment.
Non-blocking nit; you could also do
Suggested change
| let testPage: Page; | |
| const testPage: Page = await obtainTestPage(context); |
and forgo the extra test step
jprusik
approved these changes
May 20, 2026
audreyality
pushed a commit
that referenced
this pull request
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-37816
📔 Objective
Removes checks for the welcome page, as that page is removed in bitwarden/clients#20755.
The method is re-scoped to just close all other tabs and return the first one, as it would have previously if the welcome tab were disabled.