Skip to content

[PM-38629] Update server selection menu item for BIT configuration#498

Merged
jprusik merged 1 commit into
mainfrom
pm-38629
Jun 8, 2026
Merged

[PM-38629] Update server selection menu item for BIT configuration#498
jprusik merged 1 commit into
mainfrom
pm-38629

Conversation

@jprusik

@jprusik jprusik commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

🎟️ Tracking

PM-38629

📔 Objective

The reference to the environment selector menu item for “self-hosted” has changed and needs to be updated for BIT to run properly again:
https://github.com/bitwarden/browser-interactions-testing/actions/runs/27037098379/job/79803735815

@jprusik jprusik self-assigned this Jun 5, 2026
@jprusik jprusik added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-line locator update in fixtures/extension-setup.ts that swaps the "self-hosted" environment selector item from getByRole("menuitem", ...) to a scoped #cdk-overlay-0 + getByRole("button", ...) lookup. The change is narrowly targeted at unblocking the CI failure referenced in PM-38629 (the client's environment selector item role changed from menuitem to button inside a CDK overlay). Scope is limited to test fixture setup; no production code, security boundaries, or test data are affected.

Code Review Details

No findings.

@jprusik jprusik merged commit a68c715 into main Jun 8, 2026
19 of 22 checks passed
@jprusik jprusik deleted the pm-38629 branch June 8, 2026 13:28
jprusik added a commit that referenced this pull request Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants