Skip to content

Revert "update server selection menu item for BIT configuration (#498)"#500

Merged
jprusik merged 1 commit into
mainfrom
pm-38629-attempt-2
Jun 9, 2026
Merged

Revert "update server selection menu item for BIT configuration (#498)"#500
jprusik merged 1 commit into
mainfrom
pm-38629-attempt-2

Conversation

@jprusik

@jprusik jprusik commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

This reverts commit a68c715.

@jprusik jprusik added the ai-review-vnext Request a Claude code review using the vNext workflow label Jun 9, 2026
@jprusik jprusik self-assigned this Jun 9, 2026
@jprusik jprusik marked this pull request as ready for review June 9, 2026 20:55
@jprusik jprusik requested a review from a team as a code owner June 9, 2026 20:55
@jprusik jprusik requested a review from blackwood June 9, 2026 20:55
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR reverts the selector change introduced in #498, restoring the getByRole("menuitem", { name: "self-hosted" }) lookup in fixtures/extension-setup.ts. The reverted-to selector is semantic and consistent with existing patterns in the codebase (e.g., tests/a11y/web-client.spec.ts:48). The removed #cdk-overlay-0 selector relied on a sequentially generated Angular CDK ID, which is fragile if other overlays render first. The change is minimal and isolated; no code-level findings.

Code Review Details

No inline findings.

PR Metadata Assessment

  • QUESTION: The PR description is the default "This reverts commit ..." message and omits the project's PR template sections (Tracking, Objective). Since this revert undoes a fix targeting BIT configuration, please add context on why the revert is needed (e.g., is the original selector failing somewhere, is a different fix planned?) so future readers and reviewers understand the intent.

@jprusik jprusik enabled auto-merge (squash) June 9, 2026 21:00
@jprusik jprusik merged commit 3481caa into main Jun 9, 2026
15 of 18 checks passed
@jprusik jprusik deleted the pm-38629-attempt-2 branch June 9, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants