PM-39413 Update BIT tests to bypass new prompt

[dan-livefront]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39413

📔 Objective

The new default password manager prompt on new installs is blocking setup, this change will skip the prompt. We can later expand to testing the prompt if we find value in doing so.

Note

This will be merged after the permissions prompt pr

Test all run against [the permissions prompt pr](https://github.com/bitwarden/clients/pull/21391) : 

https://github.com/bitwarden/browser-interactions-testing/actions/runs/28030173339

Test with flags run against [the permissions prompt pr](https://github.com/bitwarden/clients/pull/21391) : 

https://github.com/bitwarden/browser-interactions-testing/actions/runs/28030208742

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Reviewed a single-file change to fixtures/extension-setup.ts adding dismissDefaultPasswordManagerPrompt, wired into prepareEnvironment after the welcome carousel. The implementation treats the new default-password-manager prompt as optional: waitForURL matches either the prompt URL or login, then early-returns when not on the prompt page and only clicks Skip when the prompt is actually present. This resolves the earlier hard-wait concern and the reviewer request to keep the expectation optional if the prompt is feature-flagged off.

Code Review Details

No blocking findings. The change is focused, follows the existing defaultGotoOptions / defaultWaitForOptions conventions, and correctly tolerates the prompt being absent.

[claude]

⚠️ IMPORTANT: This hard-waits for the prompt, making setup fail on builds where it is absent.

Details and fix

skipButton.waitFor(defaultWaitForOptions) uses state: "visible" with a 15s timeout. If the default-password-manager prompt is not rendered — e.g. an older build artifact, or a build/flag state where this new prompt does not appear — waitFor throws a TimeoutError, failing prepareEnvironment and breaking the entire test (and benchmark) setup rather than the prompt being optional.

This suite is designed to run against varying real MV3 builds (see the prod/CI note on closeWelcomePage), and the codebase already handles mid-rollout UI variability defensively — see loginToVault using .or() at lines 113-120 with a comment explaining the rollout state.

Consider tolerating the prompt's absence, e.g.:

const skipButton = testPage
  .locator("autofill-default-password-manager-prompt")
  .getByRole("button", { name: "Skip" });

if (await skipButton.isVisible().catch(() => false)) {
  await skipButton.click();
}

or wrapping the existing waitFor/click in a try/catch that swallows the timeout, so the prompt is treated as optional rather than required.

If the prompt is in fact guaranteed to be present in every build this suite runs against, this can be dismissed.

[jprusik]

Is it guaranteed to appear every time (not gated by a feature flag or other server config)?

[jprusik]

We could also enable disabling the prompt via dev flag, a la skipWelcomeOnInstall in the clients project

[dan-livefront]

After bitwarden/clients#21391 merges, the prompt should appear on every new install. We currently aren't feature flagging this work but it may make sense to since it could potentially be blocking for a login

[jprusik]

If you flag it on the client, you'll need to come back here and update the expectation to be optional (not fail) if the prompt doesn't appear within the timeout

[jprusik]

Approving assuming it will be merged alongside the corresponding client changes