Skip to content

[PM-30483] Remove feature flagged logic for passkey unlock#19798

Merged
eligrubb merged 3 commits into
mainfrom
km/pm-30483/remove-ff-passkey-unlock
Apr 20, 2026
Merged

[PM-30483] Remove feature flagged logic for passkey unlock#19798
eligrubb merged 3 commits into
mainfrom
km/pm-30483/remove-ff-passkey-unlock

Conversation

@eligrubb
Copy link
Copy Markdown
Member

@eligrubb eligrubb commented Mar 26, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-30483

📔 Objective

Now that passkey unlock has been released, this change, along with server PR#7318, removes the logic related to the passkey unlock feature flag pm-2035-passkey-unlock. The feature flag itself will be removed in a future ticket: https://bitwarden.atlassian.net/browse/PM-30484

📸 Screenshots

@eligrubb eligrubb added the ai-review-vnext Request a Claude code review using the vNext workflow label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 26, 2026

Overall Assessment: APPROVE

Clean removal of the pm-2035-passkey-unlock feature flag (FeatureFlag.PasskeyUnlock). The PR removes the flag enum entry and its default value, strips the ConfigService and KeyService dependencies that were only needed for the flag check, and updates all three DI registration sites (browser, desktop, web) so the deps arrays match the updated constructor signature. No remaining references to the removed flag were found in the codebase.

Code Review Details

No findings. All changes are consistent and correctly applied.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.49%. Comparing base (e6e8213) to head (4c31355).
⚠️ Report is 286 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19798   +/-   ##
=======================================
  Coverage   46.49%   46.49%           
=======================================
  Files        3850     3850           
  Lines      114912   114905    -7     
  Branches    17508    17507    -1     
=======================================
- Hits        53423    53422    -1     
+ Misses      59056    59050    -6     
  Partials     2433     2433           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 26, 2026

Logo
Checkmarx One – Scan Summary & Details418ec95a-bf46-4ef7-93ac-68311a2b485b

Great job! No new security vulnerabilities introduced in this pull request

@eligrubb eligrubb force-pushed the km/pm-30483/remove-ff-passkey-unlock branch from e5ad046 to 4c31355 Compare March 26, 2026 23:46
@eligrubb eligrubb marked this pull request as ready for review March 26, 2026 23:47
@eligrubb eligrubb requested review from a team as code owners March 26, 2026 23:47
@eligrubb eligrubb requested review from coroiu and mzieniukbw March 26, 2026 23:47
@sonarqubecloud
Copy link
Copy Markdown

@eligrubb eligrubb removed the ai-review-vnext Request a Claude code review using the vNext workflow label Mar 27, 2026
Copy link
Copy Markdown
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking good. Approving for platform

@djsmith85 djsmith85 removed the request for review from coroiu March 27, 2026 08:27
@eligrubb eligrubb merged commit 6f0a725 into main Apr 20, 2026
144 checks passed
@eligrubb eligrubb deleted the km/pm-30483/remove-ff-passkey-unlock branch April 20, 2026 20:29
jaasen-livefront pushed a commit that referenced this pull request Apr 22, 2026
Now that passkey unlock has been released, this change removes the logic related to the passkey unlock feature flag pm-2035-passkey-unlock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants