[PM-34119] Web New Item Dialog#19953
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19953 +/- ##
==========================================
+ Coverage 46.74% 46.81% +0.06%
==========================================
Files 3879 3887 +8
Lines 116181 117069 +888
Branches 17700 17904 +204
==========================================
+ Hits 54313 54801 +488
- Misses 59395 59786 +391
- Partials 2473 2482 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (19)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
nick-livefront
commented
Apr 2, 2026
Collaborator
Author
There was a problem hiding this comment.
@bitwarden/team-ui-foundation One change here to support the designs of the new item dialog. Figma
- The dialog without a footer currently has extra padding on the bottom. I added a
hasFooterconditional to only render the wrapping<div>when present. This also why there are storybook changes for existing implementations of the dialog.
jrmccannon
requested changes
Apr 13, 2026
Contributor
jrmccannon
left a comment
jrmccannon
left a comment
There was a problem hiding this comment.
Looks good. Just a few comments.
Member
shane-melton
left a comment
shane-melton
left a comment
There was a problem hiding this comment.
Looks good, nice work! Just have one question/suggestion around the public API of the add-item-grid component.
|
vleague2
approved these changes
Apr 14, 2026
nikwithak
pushed a commit
that referenced
this pull request
Apr 15, 2026
* when the footer is not present in the dialog remove empty div * add new item type feature flag * add subtitle text to cipher menu items * add add item dialog and associated components * integrate the new item dialog into web and AC vaults * add dialog header start slot for dialog * fix menu trigger when feature flag is disabled * add back button for cipher dialogs * bind `this` for back action * only show back button when a new cipher is being created * fix edit access for new ciphers * fix logic for adding a cipher and showing the back button * add back action to the collection dialog * add back action to folder dialog * fix formatting and strict types * update backAction getter for consistency * add story without footer * prettier fixes * address local claude feedback * update icons on dialog * adjust spacing and sizes * fix strict typings * add typography import * design pass after working on other platforms * update to use the icon tile component * address feedback from design * update grid to use bit item * remove dialog description * update to single column when less than 6 items * Revert "add dialog header start slot for dialog" This reverts commit e029cde. * remove back action for new cipher dialog * match padding-top of dialog when there is no footer * fix alignment of carrot * remove tests associated back action * use default bit-item styles for typography * reduce margin of bit-item * prefer `inject` function * add readonly and protected * move types into the grid component to streamline the api integration
djsmith85
added
cli
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-34119
📔 Objective
Adds new item selection dialog in preparation for the addition of Bank Account, Driver's License, and Passport cipher types.
AddItemGridComponentthat stores all logic for for which item types are visible and is cross platform compatible.PM32009NewItemTypesfeature flag is enabled the new button on the web vault and admin console will open the dialog rather than the dropdown menu.📸 Screenshots
web-dark-mode.mov
web-light-mode.mov