Misc cleanup to make the components use modern angular#19967
Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## PM-33889-Innovation-sprint-Bitwarden-Receive #19967 +/- ##
================================================================================
+ Coverage 46.34% 46.36% +0.02%
================================================================================
Files 3900 3861 -39
Lines 115929 114943 -986
Branches 17602 17515 -87
================================================================================
- Hits 53729 53297 -432
+ Misses 59756 59218 -538
+ Partials 2444 2428 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
New Issues (32)Checkmarx found the following issues in this Pull Request
|
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |
7958d5a
into
PM-33889-Innovation-sprint-Bitwarden-Receive







🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34599
📔 Objective
ReceiveService.buildReceiveUrl$(), removing identicalbaseReceiveUrl/buildReceiveUrlpatterns from 3 components (ReceiveViewComponent,ReceiveSuccessComponent,ReceiveComponent)ReceiveComponentto OnPush change detection with signals (toSignal,computed,model,effect) replacing imperativetakeUntilDestroyedsubscriptionReceiveViewComponentfrom constructor DI toinject()and replaces manual copy-to-clipboard withappCopyClickdirectiveReceiveTableComponentby pre-computingexpiredstate in aReceiveRowtype and moving the row click handler to<tr>ReceiveFilesViewComponenttemplate — removes redundant section/card wrapper (now handled by parent)confirmDeleteReceiveand new i18n messagesreceive-view.tsfile andreceives$from publicReceiveServiceAPI (moved toprivatein implementation); addsdelete()toInternalReceiveService