Skip to content

[PM-34036] Skip corrupted attachments during zip vault export#19976

Merged
gbubemismith merged 19 commits into
mainfrom
vault/PM-34036-skip-attachments
May 5, 2026
Merged

[PM-34036] Skip corrupted attachments during zip vault export#19976
gbubemismith merged 19 commits into
mainfrom
vault/PM-34036-skip-attachments

Conversation

@gbubemismith
Copy link
Copy Markdown
Contributor

@gbubemismith gbubemismith commented Apr 3, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34036

📔 Objective

Skip corrupted attachments during zip vault export instead of aborting the entire export. When attachments fail to decrypt, the export completes with all valid vault data and attachments, and a warning callout informs the user how many attachments were skipped. Additionally, the export scope description is converted from a callout to inline text to match the updated design.

📸 Screenshots

Web Browser Desktop
Screen.Recording.2026-04-03.at.22.24.08.mov
Screen.Recording.2026-04-02.at.15.48.51.mov
new_edit.mov

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 3, 2026

Codecov Report

❌ Patch coverage is 50.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.09%. Comparing base (3213690) to head (6631b23).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...pup/settings/export/export-browser-v2.component.ts 0.00% 4 Missing ⚠️
...p/src/app/tools/export/export-desktop.component.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19976      +/-   ##
==========================================
- Coverage   47.10%   47.09%   -0.01%     
==========================================
  Files        3948     3948              
  Lines      119688   119698      +10     
  Branches    18344    18347       +3     
==========================================
  Hits        56374    56374              
- Misses      59080    59090      +10     
  Partials     4234     4234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

Logo
Checkmarx One – Scan Summary & Detailsdd026b8f-0152-4f15-a718-79d6af79942b

Great job! No new security vulnerabilities introduced in this pull request

@gbubemismith gbubemismith requested a review from a team April 3, 2026 21:07
@gbubemismith gbubemismith marked this pull request as ready for review April 3, 2026 21:07
@gbubemismith gbubemismith requested a review from a team as a code owner April 3, 2026 21:07
mcamirault
mcamirault previously approved these changes Apr 7, 2026
mcamirault
mcamirault previously approved these changes Apr 14, 2026
@sonarqubecloud
Copy link
Copy Markdown

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 4, 2026

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented May 4, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented May 4, 2026

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@gbubemismith gbubemismith merged commit afd36d2 into main May 5, 2026
134 checks passed
@gbubemismith gbubemismith deleted the vault/PM-34036-skip-attachments branch May 5, 2026 16:56
Comment on lines +4568 to +4576
"exportSuccessSkippedAttachments": {
"message": "$COUNT$ corrupted attachments were skipped during export. All other vault data and attachments exported successfully.",
"placeholders": {
"count": {
"content": "$1",
"example": "3"
}
}
},
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't translate in any correct way :( What's going on with full plural support in web/browser/desktop app?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants