[PM-24795] When logged out, "(empty)" options appear under File#19982
Merged
jengstrom-bw merged 7 commits intoApr 10, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19982 +/- ##
==========================================
+ Coverage 46.68% 46.72% +0.04%
==========================================
Files 3880 3879 -1
Lines 116128 116085 -43
Branches 17674 17678 +4
==========================================
+ Hits 54215 54246 +31
+ Misses 59444 59372 -72
+ Partials 2469 2467 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
…-appear-under-File
shane-melton
reviewed
Apr 8, 2026
Member
shane-melton
left a comment
shane-melton
left a comment
There was a problem hiding this comment.
Logic changes look good, I'd just suggest we add some tests to prevent this from happening again in the future.
|
Contributor
Author
|
Added tests and removed unneeded |
shane-melton
approved these changes
Apr 9, 2026
jengstrom-bw
deleted the
vault/pm-24795/when-logged-out-empty-options-appear-under-File
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
Jira
📔 Objective
Fix
Lock VaultandLog Outmenu item enabled state when there are no lockable or authenticated accounts