Skip to content

[PM-34668] fix(desktop): sync @napi-rs/cli lockfile entry#19997

Open
caverav wants to merge 3 commits into
bitwarden:mainfrom
caverav:fix-desktop-napi-lockfile
Open

[PM-34668] fix(desktop): sync @napi-rs/cli lockfile entry#19997
caverav wants to merge 3 commits into
bitwarden:mainfrom
caverav:fix-desktop-napi-lockfile

Conversation

@caverav
Copy link
Copy Markdown

@caverav caverav commented Apr 5, 2026

Summary

Sync the stale @napi-rs/cli entry in the root package-lock.json with the version already declared by apps/desktop/desktop_native/napi/package.json.

The desktop NAPI workspace already depends on @napi-rs/cli 3.5.1, but the nested lockfile entry still points to 3.2.0.

Why

This keeps the workspace and lockfile consistent and avoids downstream/offline tooling failures caused by the mismatch.

Notes

There is already an open draft PR touching this as part of a larger Angular/Storybook update, but this change is standalone and limited to the lockfile inconsistency.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 5, 2026

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link
Copy Markdown
Collaborator

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-34668
Link: https://bitwarden.atlassian.net/browse/PM-34668

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@bitwarden-bot bitwarden-bot changed the title fix(desktop): sync @napi-rs/cli lockfile entry [PM-34668] fix(desktop): sync @napi-rs/cli lockfile entry Apr 5, 2026
@bitwarden-bot bitwarden-bot added community-pr needs-qa Marks a PR as requiring QA approval labels Apr 5, 2026
@caverav
Copy link
Copy Markdown
Author

caverav commented Apr 18, 2026

Hi, any update on this? It's causing bugs in downstream builds.

@djsmith85 djsmith85 linked an issue May 5, 2026 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-pr needs-qa Marks a PR as requiring QA approval

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm ci fails due to out-of-sync package-lock.json (npm 11.12.1)

3 participants