Skip to content

Desktop Native: Clean up SSH Agent v1 deps#20733

Draft
neuronull wants to merge 3 commits into
mainfrom
dn/pm-37766/clean-up-ssh-agent-v1-deps
Draft

Desktop Native: Clean up SSH Agent v1 deps#20733
neuronull wants to merge 3 commits into
mainfrom
dn/pm-37766/clean-up-ssh-agent-v1-deps

Conversation

@neuronull
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37766

📔 Objective

While digging into

#20578

and

#20582

, I noticed these are only transitive deps. I then noticed this is the case for some others. So this task is to clean that up.

📸 Manual testing

Built and ran the SSH Agent , confirmed list keys and signing work.

@neuronull neuronull self-assigned this May 19, 2026
@neuronull neuronull added dependencies Pull requests that update a dependency file desktop Desktop Application ai-review Request a Claude code review labels May 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes four transitively-resolved crates (ed25519, pkcs8, russh-cryptovec, ssh-encoding) from [workspace.dependencies] in apps/desktop/desktop_native/Cargo.toml, and relocates bitwarden-russh, rsa, sha2, and ssh-key to be declared inline in core/Cargo.toml (their sole consumer in the workspace, alongside the already-inline ssh-key declaration in ssh_agent/Cargo.toml). The .github/renovate.json5 Desktop Native ownership group is updated to drop the removed ed25519 and pkcs8 entries. Verified via grep that no Rust source under apps/desktop/desktop_native/ contains use statements for any of the removed crates (the surviving "ed25519" strings are SSH algorithm identifiers and ssh-key feature flags, not crate imports), and that Cargo.lock is unchanged — confirming this is a pure declaration-site refactor with no resolution impact.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.45%. Comparing base (d7d7482) to head (80584cb).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20733      +/-   ##
==========================================
- Coverage   47.46%   47.45%   -0.01%     
==========================================
  Files        4002     4002              
  Lines      123118   123118              
  Branches    18939    18939              
==========================================
- Hits        58434    58429       -5     
- Misses      60262    60266       +4     
- Partials     4422     4423       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review dependencies Pull requests that update a dependency file desktop Desktop Application

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant