Skip to content

Dirt/pm 34724/carousel for first time admins#20734

Open
voommen-livefront wants to merge 14 commits into
mainfrom
dirt/pm-34724/carousel-for-first-time-admins
Open

Dirt/pm 34724/carousel for first time admins#20734
voommen-livefront wants to merge 14 commits into
mainfrom
dirt/pm-34724/carousel-for-first-time-admins

Conversation

@voommen-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-34724

📔 Objective

  1. Added new dev-menu option to monitor user state updates and to invoke the new dialog
  2. Created a new dialog reusing Vault Carousel
  3. Invoke the dialog when there are no access intelligence reports are found and when the org has no ciphers
  4. Renamed the dialogs for better name
  • Post Import Dialog - renders when there are no reports but there are ciphers
  • New Admin Welcome dialog - renders when the org has no ciphers and no access intelligence reports

📸 Screenshots

Added new dev-menu options to invoke the welcome carousel

image

###New Carousel dialog for new admins
Screenshot 2026-05-19 at 1 36 16 PM
Screenshot 2026-05-19 at 1 36 12 PM
Screenshot 2026-05-19 at 1 36 07 PM
Screenshot 2026-05-19 at 1 36 02 PM

@voommen-livefront voommen-livefront requested review from a team as code owners May 19, 2026 18:39
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

❌ Patch coverage is 33.64486% with 71 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.46%. Comparing base (cdbe896) to head (f94871e).
⚠️ Report is 8 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...t/access-intelligence/shared/dev-menu.component.ts 0.00% 27 Missing ⚠️
...ding/new-admin-welcome-dialog.component.stories.ts 0.00% 14 Missing ⚠️
...irt/access-intelligence/risk-insights.component.ts 0.00% 11 Missing ⚠️
...e/onboarding/new-admin-welcome-dialog.component.ts 70.96% 9 Missing ⚠️
...lligence/onboarding/services/onboarding.service.ts 61.53% 5 Missing ⚠️
...e/onboarding/post-import-modal-dialog.component.ts 66.66% 2 Missing ⚠️
.../vault/src/components/carousel/carousel.stories.ts 0.00% 2 Missing ⚠️
...ligence-page/access-intelligence-page.component.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20734      +/-   ##
==========================================
+ Coverage   47.44%   47.46%   +0.02%     
==========================================
  Files        4002     4005       +3     
  Lines      123116   123224     +108     
  Branches    18938    18947       +9     
==========================================
+ Hits        58414    58493      +79     
- Misses      60277    60305      +28     
- Partials     4425     4426       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment on lines +62 to +64
// FIXME(https://bitwarden.atlassian.net/browse/CL-903): Migrate to Signals
// eslint-disable-next-line @angular-eslint/prefer-signals
@Input({ transform: booleanAttribute }) hideArrows = false;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be updated to use an input signal? Would like to not add new //FIXME comments

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! I shouldn't introduce further technical debt. I have this fixed.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@jengstrom-bw jengstrom-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vault items look good, thanks for updating that signal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants