[PM-33906] Use PureCrypto::new_guid for FIDO2 credential ID by dereknance · Pull Request #20736 · bitwarden/clients

dereknance · 2026-05-19T19:35:02Z

🎟️ Tracking

📔 Objective

Update Fido2CredentialView to set credentialId using PureCrypto.new_guid().

github-actions · 2026-05-19T19:36:46Z

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR replaces Utils.newGuid() with PureCrypto.new_guid() in createKeyView() for FIDO2 credential ID generation, and adds await SdkLoadService.Ready to ensure the SDK WASM module is initialized before use. The test setup adds the matching mocks for SdkLoadService.Ready and PureCrypto.new_guid, following the established pattern in encrypt.service.spec.ts. The change is narrow, well-scoped, and directly addresses the prior reviewer feedback from dani-garcia regarding SDK readiness.

Code Review Details

No findings. The implementation follows existing codebase conventions for SDK-backed operations (matches patterns in encrypt.service.implementation.ts, default-unlock.service.ts, and other PureCrypto consumers). The test mock approach mirrors libs/common/src/key-management/crypto/services/encrypt.service.spec.ts:53.

codecov · 2026-05-19T19:45:16Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.46%. Comparing base (0345984) to head (bfffbf0).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #20736   +/-   ##
=======================================
  Coverage   47.46%   47.46%           
=======================================
  Files        4003     4003           
  Lines      123145   123148    +3     
  Branches    18945    18945           
=======================================
+ Hits        58447    58450    +3     
  Misses      60272    60272           
  Partials     4426     4426

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dereknance · 2026-05-19T19:46:15Z

    "@ngtools/webpack": "21.2.9",
+    "@nx/devkit": "22.6.5",
+    "@nx/eslint": "22.6.5",
+    "@nx/jest": "22.6.5",
+    "@nx/js": "22.6.5",
+    "@nx/webpack": "22.6.5",
    "@storybook/addon-a11y": "10.3.6",
    "@storybook/addon-designs": "11.1.3",
    "@storybook/addon-docs": "10.3.6",
    "@storybook/addon-links": "10.3.6",
    "@storybook/addon-themes": "10.3.6",
    "@storybook/angular": "10.3.6",
    "@storybook/test-runner": "0.24.3",
    "@storybook/web-components-vite": "10.3.6",
-    "@nx/devkit": "22.6.5",
-    "@nx/eslint": "22.6.5",
-    "@nx/jest": "22.6.5",
-    "@nx/js": "22.6.5",
-    "@nx/webpack": "22.6.5",
    "@tailwindcss/container-queries": "0.1.1",
    "@types/chrome": "0.1.28",
    "@types/firefox-webext-browser": "143.0.0",
    "@types/inquirer": "8.2.10",
    "@types/jest": "30.0.0",
    "@types/jsdom": "28.0.1",
    "@types/koa": "3.0.1",
    "@types/koa__multer": "2.0.7",
    "@types/koa-bodyparser": "4.3.7",
    "@types/koa-json": "2.0.24",
    "@types/lowdb": "1.0.15",
    "@types/lunr": "2.3.7",
    "@types/node": "22.19.17",
    "@types/node-fetch": "2.6.13",
    "@types/node-forge": "1.3.14",
    "@types/papaparse": "5.5.2",
    "@types/proper-lockfile": "4.1.4",
    "@types/retry": "0.12.5",
    "@types/zxcvbn": "4.4.5",
    "@typescript-eslint/rule-tester": "8.59.1",
    "@typescript-eslint/utils": "8.59.1",
    "@webcomponents/custom-elements": "1.6.0",
    "@yao-pkg/pkg": "6.5.1",
    "angular-eslint": "20.7.0",
    "autoprefixer": "10.4.22",
    "axe-playwright": "2.2.2",
    "babel-loader": "10.1.1",
    "base64-loader": "1.0.0",
    "browserslist": "4.28.2",
    "chromatic": "13.3.4",
    "concurrently": "9.2.1",
    "copy-webpack-plugin": "14.0.0",
    "cross-env": "10.1.0",
    "css-loader": "7.1.4",
    "electron": "39.8.5",
    "electron-builder": "26.8.2",
    "electron-log": "5.4.3",
    "electron-reload": "2.0.0-alpha.1",
    "electron-store": "11.0.2",
    "electron-updater": "6.6.4",
    "eslint": "9.39.4",
    "eslint-config-prettier": "10.1.8",
    "eslint-import-resolver-typescript": "4.4.4",
    "eslint-plugin-import": "2.32.0",
    "eslint-plugin-jest": "29.15.2",
    "eslint-plugin-rxjs": "5.0.3",
    "eslint-plugin-rxjs-angular": "2.0.1",
    "eslint-plugin-storybook": "10.3.6",
    "eslint-plugin-tailwindcss": "3.18.3",
    "fantasticon": "4.1.0",
    "html-loader": "5.1.0",
    "html-webpack-injector": "1.1.4",
    "html-webpack-plugin": "5.6.6",
    "husky": "9.1.7",
    "jest": "30.3.0",
    "jest-diff": "30.3.0",
    "jest-environment-jsdom": "29.7.0",
    "jest-junit": "17.0.0",
    "jest-mock-extended": "4.0.1",
    "jest-preset-angular": "16.1.4",
    "json5": "2.2.3",
    "lint-staged": "16.4.0",
    "mini-css-extract-plugin": "2.10.2",
    "nx": "22.6.5",
    "path-browserify": "1.0.1",
    "postcss": "8.5.10",
    "postcss-loader": "8.2.1",
    "prettier": "3.8.1",
    "prettier-plugin-tailwindcss": "0.8.0",
    "process": "0.11.10",
    "remark-gfm": "4.0.1",
    "rimraf": "6.1.2",
-    "storybook": "10.3.6",
    "sass": "1.99.0",
    "sass-loader": "16.0.7",
+    "storybook": "10.3.6",
    "style-loader": "4.0.0",


I'm not sure how these became out of order, but I figured I'd include the sort in this PR.

dani-garcia

LGTM just a small suggestion. You also have some conflicts to solve

dani-garcia · 2026-05-20T11:27:07Z

  const pkcs8Key = new Uint8Array(await crypto.subtle.exportKey("pkcs8", keyValue));
  const fido2Credential = new Fido2CredentialView();
-  fido2Credential.credentialId = Utils.newGuid();
+  fido2Credential.credentialId = PureCrypto.new_guid();


We should probably do await SdkLoadService.Ready; before we use purecrypto to ensure that the SDK is initialized on time

Fixed! 88d336b

…to-new-guid # Conflicts: # package-lock.json # package.json

sonarqubecloud · 2026-05-20T17:16:51Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Use PureCrypto::new_guid for FIDO2 credential ID

4590e2e

dereknance added the ai-review Request a Claude code review label May 19, 2026

dereknance commented May 19, 2026

View reviewed changes

dereknance marked this pull request as ready for review May 19, 2026 20:25

dereknance requested a review from a team as a code owner May 19, 2026 20:25

dereknance requested a review from dani-garcia May 19, 2026 20:25

dani-garcia reviewed May 20, 2026

View reviewed changes

dereknance added 2 commits May 20, 2026 11:56

Add SDK ready check

88d336b

Merge remote-tracking branch 'origin/main' into pm-33906-use-purecryp…

bfffbf0

…to-new-guid # Conflicts: # package-lock.json # package.json

dereknance requested a review from dani-garcia May 20, 2026 18:43

dani-garcia approved these changes May 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-33906] Use PureCrypto::new_guid for FIDO2 credential ID#20736

[PM-33906] Use PureCrypto::new_guid for FIDO2 credential ID#20736
dereknance wants to merge 3 commits into
mainfrom
pm-33906-use-purecrypto-new-guid

dereknance commented May 19, 2026 •

edited by atlassian Bot

Loading

Uh oh!

github-actions Bot commented May 19, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 19, 2026 •

edited

Loading

Uh oh!

dereknance May 19, 2026

Uh oh!

dani-garcia left a comment

Uh oh!

dani-garcia May 20, 2026

Uh oh!

dereknance May 20, 2026

Uh oh!

sonarqubecloud Bot commented May 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

dereknance commented May 19, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎟️ Tracking

📔 Objective

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Bitwarden Claude Code Review

Uh oh!

codecov Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dereknance May 19, 2026

Choose a reason for hiding this comment

Uh oh!

dani-garcia left a comment

Choose a reason for hiding this comment

Uh oh!

dani-garcia May 20, 2026

Choose a reason for hiding this comment

Uh oh!

dereknance May 20, 2026

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented May 20, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

dereknance commented May 19, 2026 •

edited by atlassian Bot

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading

codecov Bot commented May 19, 2026 •

edited

Loading