[PM-37759] Unable to use passkey that is stored in my vault to log in

[jengstrom-bw]

🎟️ Tracking

Jira

📔 Objective

This should fix the ability to see and use passkeys to authenticate using the browser with feature flag pm-27632-cipher-crud-operations-to-sdk turned on.

[github-actions]

Bitwarden Claude Code Review

Overall Assessment: APPROVE

This change extends the prior getAllDecrypted fix (commit 2eba6cac69) to thread the SDK CiphersClient through every remaining call site of toSdkCipherView and fromSdkCipherView in DefaultCipherSdkService. Without the client, the FIDO2 branches in cipher.view.ts (lines 355-367 and 582-587) are skipped, silently dropping passkey credentials on returned views and on views serialized for SDK calls. The fix mirrors the existing pattern in createWithServer and updateWithServer and is the right scope to fully resolve PM-37759 under the pm-27632-cipher-crud-operations-to-sdk flag.

Code Review Details

No blocking findings.

• The prior bot review already noted the absence of a getAllDecrypted FIDO2 regression test. That observation now also applies to shareWithServer, shareManyWithServer, saveCollectionsWithServer, and saveCollectionsWithServerAdmin, which lack the FIDO2 assertions present in the createWithServer / updateWithServer specs (libs/common/src/vault/services/cipher-sdk.service.spec.ts:165, :310). Not flagged inline to avoid duplicating the earlier suggestion.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.46%. Comparing base (7d214cc) to head (3548f61).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #20738   +/-   ##
=======================================
  Coverage   47.46%   47.46%           
=======================================
  Files        4002     4003    +1     
  Lines      123125   123150   +25     
  Branches    18940    18945    +5     
=======================================
+ Hits        58437    58457   +20     
- Misses      60266    60268    +2     
- Partials     4422     4425    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nikwithak]

Nice work! Hopefully we don't have any more stragglers that don't pass the sdkClient

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud