[PM-37779] - Add notification bar confirmation mode for inline menu save flow#20752
[PM-37779] - Add notification bar confirmation mode for inline menu save flow#20752jaasen-livefront wants to merge 2 commits into
Conversation
Adds the ability to open the notification bar directly in the "Login saved" confirmation state, bypassing the normal "Save login?" prompt. This is used when a cipher is saved via the inline menu "Save and fill" button — the popup handles the autofill itself and then needs to show a confirmation bar on the originating tab. Changes: - NotificationBarIframeInitData: add isConfirmation and confirmationData - bar.ts: short-circuit to confirmation state when isConfirmation is set - NotificationsExtensionMessage: thread isConfirmation/confirmationData through the content service to the bar iframe - notification.background: add triggerLoginSavedNotification (opens bar in confirmation state on a given tab) and showLoginSavedNotification message handler (called by the popup after autofill)
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20752 +/- ##
==========================================
- Coverage 47.46% 47.45% -0.01%
==========================================
Files 4003 4003
Lines 123145 123158 +13
Branches 18945 18950 +5
==========================================
+ Hits 58447 58448 +1
- Misses 60272 60284 +12
Partials 4426 4426 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-37779
📔 Objective
Adds the infrastructure needed to open the notification bar directly in
the "Login saved" confirmation state, bypassing the normal "Save login?"
prompt. This is a prerequisite for the "Save and fill" inline menu flow
(PR 2), but is independently useful — it decouples the confirmation
notification from the save-prompt lifecycle.
Changes:
NotificationBarIframeInitData: addisConfirmationandconfirmationDatafieldsbar.ts: whenisConfirmationis set, short-circuit to thepost-save confirmation state rather than rendering the "Save login?"
prompt
overlay-notifications-content.service.ts(abstractions +implementation): thread
isConfirmation/confirmationDatathroughfrom the
openNotificationBarmessage to the bar iframe init datanotification.background.ts: addtriggerLoginSavedNotification—sends
openNotificationBarwithisConfirmation: trueto a giventab; add
showLoginSavedNotificationmessage handler — looks up thetab by
senderTabIdand callstriggerLoginSavedNotification📸 Screenshots