Skip to content

[PM-37779] - Add notification bar confirmation mode for inline menu save flow#20752

Draft
jaasen-livefront wants to merge 2 commits into
mainfrom
PM-37779
Draft

[PM-37779] - Add notification bar confirmation mode for inline menu save flow#20752
jaasen-livefront wants to merge 2 commits into
mainfrom
PM-37779

Conversation

@jaasen-livefront
Copy link
Copy Markdown
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-37779

📔 Objective

Adds the infrastructure needed to open the notification bar directly in
the "Login saved" confirmation state, bypassing the normal "Save login?"
prompt. This is a prerequisite for the "Save and fill" inline menu flow
(PR 2), but is independently useful — it decouples the confirmation
notification from the save-prompt lifecycle.

Changes:

  • NotificationBarIframeInitData: add isConfirmation and
    confirmationData fields
  • bar.ts: when isConfirmation is set, short-circuit to the
    post-save confirmation state rather than rendering the "Save login?"
    prompt
  • overlay-notifications-content.service.ts (abstractions +
    implementation): thread isConfirmation / confirmationData through
    from the openNotificationBar message to the bar iframe init data
  • notification.background.ts: add triggerLoginSavedNotification
    sends openNotificationBar with isConfirmation: true to a given
    tab; add showLoginSavedNotification message handler — looks up the
    tab by senderTabId and calls triggerLoginSavedNotification

📸 Screenshots

Adds the ability to open the notification bar directly in the
"Login saved" confirmation state, bypassing the normal "Save login?"
prompt. This is used when a cipher is saved via the inline menu
"Save and fill" button — the popup handles the autofill itself and
then needs to show a confirmation bar on the originating tab.

Changes:
- NotificationBarIframeInitData: add isConfirmation and confirmationData
- bar.ts: short-circuit to confirmation state when isConfirmation is set
- NotificationsExtensionMessage: thread isConfirmation/confirmationData
  through the content service to the bar iframe
- notification.background: add triggerLoginSavedNotification (opens bar
  in confirmation state on a given tab) and showLoginSavedNotification
  message handler (called by the popup after autofill)
@jaasen-livefront jaasen-livefront requested a review from a team as a code owner May 20, 2026 17:10
@jaasen-livefront jaasen-livefront marked this pull request as draft May 20, 2026 17:15
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.45%. Comparing base (0345984) to head (40e3149).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/autofill/background/notification.background.ts 0.00% 11 Missing ⚠️
apps/browser/src/autofill/notification/bar.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20752      +/-   ##
==========================================
- Coverage   47.46%   47.45%   -0.01%     
==========================================
  Files        4003     4003              
  Lines      123145   123158      +13     
  Branches    18945    18950       +5     
==========================================
+ Hits        58447    58448       +1     
- Misses      60272    60284      +12     
  Partials     4426     4426              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented May 20, 2026

⚠️ Changes in this PR impact the Autofill experience of the browser client ⚠️

BIT has tested the core experience with these changes and all feature flags disabled.

Caution

Unfortunately, one or more of these tests failed. 😞

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

@bw-ghapp
Copy link
Copy Markdown
Contributor

bw-ghapp Bot commented May 20, 2026

⚠️ Changes in this PR impact the Autofill experience of the browser client ⚠️

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com

Caution

Unfortunately, one or more of these tests failed. 😞

Please resolve the failure before merging; reach out to @bitwarden/team-autofill-dev if you'd like help.

You can view the detailed results of the tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant