Skip to content

[BRE-1938] Update Build Web workflow to run on published Web releases#20761

Merged
vgrassia merged 2 commits into
mainfrom
bre-1938_update-build-web-workflow
May 21, 2026
Merged

[BRE-1938] Update Build Web workflow to run on published Web releases#20761
vgrassia merged 2 commits into
mainfrom
bre-1938_update-build-web-workflow

Conversation

@vgrassia
Copy link
Copy Markdown
Member

@vgrassia vgrassia commented May 20, 2026

🎟️ Tracking

BRE-1938

📔 Objective

This PR updates the Build Web workflow to run on published Web releases that match the tag pattern web-v* instead of running on each published release in the monorepo. I also removed the Staged Rollout Desktop workflow since it has been migrated to the deploy repository.

📸 Screenshots

…ved migrated Staged Rollout Desktop workflow.
@vgrassia vgrassia requested a review from a team as a code owner May 20, 2026 21:02
@vgrassia vgrassia added the ai-review Request a Claude code review label May 20, 2026
@vgrassia vgrassia requested a review from a team as a code owner May 20, 2026 21:02
@vgrassia vgrassia requested a review from aj-bw May 20, 2026 21:02
@vgrassia vgrassia added the ai-review Request a Claude code review label May 20, 2026
@vgrassia vgrassia requested a review from coroiu May 20, 2026 21:02
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR gates build-web.yml execution on release events whose tag matches web-v* and removes the migrated staged-rollout-desktop.yml. The new check-release-tag job writes a clear step summary for non-Web releases, and the setup job's if: correctly combines always() with a short-circuit OR so non-release triggers (pull_request, push, workflow_call, workflow_dispatch) proceed via result == 'skipped' while release events are gated by startsWith(github.event.release.tag_name, 'web-v'). Logic traces cleanly across all trigger types and the prefix used by the bash check matches the prefix in the startsWith gate.

Code Review Details
  • ♻️ : Stale CODEOWNERS entry references the deleted workflow file
    • .github/CODEOWNERS:238staged-rollout-desktop.yml is deleted in this PR but still listed under the BRE team workflows section. GitHub silently ignores entries for missing files, so nothing breaks at runtime, but the line should be removed alongside the workflow deletion to keep CODEOWNERS in sync.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.46%. Comparing base (6b787c5) to head (566ce2f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20761   +/-   ##
=======================================
  Coverage   47.45%   47.46%           
=======================================
  Files        4004     4004           
  Lines      123162   123162           
  Branches    18947    18947           
=======================================
+ Hits        58448    58460   +12     
+ Misses      60287    60275   -12     
  Partials     4427     4427           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

@vgrassia vgrassia enabled auto-merge (squash) May 20, 2026 21:29
@vgrassia vgrassia merged commit 72eeec6 into main May 21, 2026
48 checks passed
@vgrassia vgrassia deleted the bre-1938_update-build-web-workflow branch May 21, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants