[PM-37782] User with view permission cannot favorite or add an item to a folder

[jengstrom-bw]

🎟️ Tracking

Jira

📔 Objective

Fix the SDK code path to allow for partial cipher updates (folder id, favorite).

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds an SDK partial-update code path so users with view-only permission can still update folder/favorite on a cipher, mirroring updateWithServerLegacy in cipher.service.ts. The mapping in CipherView.toSdkPartialUpdateCipherRequest() (id, folderId, favorite) matches the legacy CipherPartialRequest, and the branching logic in DefaultCipherSdkService.updateWithServer (orgAdmin → cipher.edit → edit_partial fallback) correctly reflects the legacy semantics. The latest commit addresses the previously raised concern: mockCiphersSdk.edit_partial is now mocked, existing tests set cipher.edit = true to keep exercising the edit branch, and new tests cover the edit_partial success path, the default-edit-false path, and the edit_partial error path with exclusivity assertions for edit and admin.

Code Review Details

No findings.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jengstrom-bw]

Needs bitwarden/sdk-internal#1114 for SDK bindings