Open
Conversation
Deploying contributing-docs with
|
| Latest commit: |
c1487c0
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f2eb0416.contributing-docs.pages.dev |
| Branch Preview URL: | https://note-about-mitm-cert.contributing-docs.pages.dev |
Thomas-Avery
requested changes
May 4, 2026
Contributor
Author
|
@Thomas-Avery Applied your feedback. Both good points! |
theMickster
requested changes
May 5, 2026
Contributor
theMickster
left a comment
theMickster
left a comment
There was a problem hiding this comment.
Minor change that was caught by a local multi-agent Claude Code session.
Co-authored-by: Mick Letofsky <mletofsky@bitwarden.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-36250
📔 Objective
The current contributing docs prescribe loading the licensing certificate as a root certificate into the OS keychain. This gives everyone with the root certificate - all bitwarden employees - the ability to spoof, intercept and tamper with all TLS traffic of all everyone who has this trusted root certificate in their keychain.
Instead of loading it into the keychain as a root certificate, this PR adds the ability to load it from a file, only for the specific scope of the
bitwarden/serverapplication, entirely eliminating this risk.📸 Screenshots