[PM-32009] polish: add bank account icon and tighten foundation gating

Relies solely on the `newItemTypes` feature flag to gate bank account
creation end-to-end. Adds the final PM-34128 bank account icon asset.

Author: SaintPatrck

BitwardenResources/Icons.xcassets/bank-account24.imageset/Contents.json

@@ -0,0 +1,16 @@
+{
+  "images" : [
+    {
+      "filename" : "bank-account24.pdf",
+      "idiom" : "universal"
+    }
+  ],
+  "info" : {
+    "author" : "xcode",
+    "version" : 1
+  },
+  "properties" : {
+    "preserves-vector-representation" : true,
+    "template-rendering-intent" : "template"
+  }
+}

BitwardenResources/Icons.xcassets/bank-account24.imageset/bank-account24.pdf

@@ -1084,9 +1084,4 @@
 "ToManageYourPremiumSubscriptionDescriptionLong" = "To manage your Premium subscription, please log in to your web vault on a computer.";
 "CheckYourConnectionAndTryAgain" = "Check your connection and try again.";
 "PricingUnavailable" = "Pricing unavailable";
-
-/* PM-32009: New Item Types — Bank Account (Part 1/3 type-level keys)
-   Field labels, account-type display names, and processor alert strings are added
-   in PM-32809 Part 2/3 and Part 3/3 as the UI surfaces that consume them land. */
-"TypeBankAccount" = "Bank account";
-"ViewBankAccount" = "View bank account";
+"BankAccount" = "Bank account";

BitwardenResources/Localizations/en.lproj/Localizable.strings

@@ -60,13 +60,10 @@ extension CipherCardModel {
 extension CipherDetailsResponseModel {
     init(cipher: BitwardenSdk.Cipher) throws {
         guard let id = cipher.id else { throw DataMappingError.invalidData }
-        // TODO: PM-32009 Blocked on SDK — map cipher.bankAccount to CipherBankAccountModel once
-        // BitwardenSdk.Cipher exposes a `bankAccount: BankAccount?` property.
-        let bankAccount: CipherBankAccountModel? = nil
         self.init(
             archivedDate: cipher.archivedDate,
             attachments: cipher.attachments?.map(AttachmentResponseModel.init),
-            bankAccount: bankAccount,
+            bankAccount: nil,
             card: cipher.card.map(CipherCardModel.init),
             collectionIds: cipher.collectionIds,
             creationDate: cipher.creationDate,
@@ -89,10 +86,7 @@ extension CipherDetailsResponseModel {
             revisionDate: cipher.revisionDate,
             secureNote: cipher.secureNote.map(CipherSecureNoteModel.init),
             sshKey: cipher.sshKey.map(CipherSSHKeyModel.init),
-            // Unknown SDK cipher types fall back to `.secureNote` on decode so
-            // pre-PM-32813 users see an opaque item rather than a crash. The
-            // backward-compat PR formalizes the "Unknown" display story.
-            type: BitwardenShared.CipherType(type: cipher.type) ?? .secureNote,
+            type: BitwardenShared.CipherType(type: cipher.type),
             viewPassword: cipher.viewPassword,
         )
     }
@@ -224,16 +218,7 @@ extension CipherSSHKeyModel {
 }
 
 extension CipherType {
-    /// Creates an app-layer `CipherType` from a `BitwardenSdk.CipherType`.
-    ///
-    /// Fails (`nil`) when the SDK value is unknown to the app — either a future SDK case
-    /// not yet mapped (e.g., `.bankAccount` while PM-32009 SDK work is pending) or a
-    /// later SDK bump that adds unmapped cases. Callers must handle `nil` rather than
-    /// assume an exhaustive mapping.
-    ///
-    /// - Parameter type: The SDK cipher type to bridge into the app layer.
-    ///
-    init?(type: BitwardenSdk.CipherType) {
+    init(type: BitwardenSdk.CipherType) {
         switch type {
         case .card:
             self = .card
@@ -245,26 +230,10 @@ extension CipherType {
             self = .secureNote
         case .sshKey:
             self = .sshKey
-        @unknown default:
-            // Route through the centralized bridge so PM-32009 and future new-type
-            // PRs flip a single switch (`NewItemTypesSdkBridge.isBankAccountAvailable`
-            // et al.) rather than updating call sites.
-            if let mapped = NewItemTypesSdkBridge.appCipherTypeForBankAccount(type) {
-                self = mapped
-                return
-            }
-            return nil
         }
     }
 
-    /// Creates an app-layer `CipherType` from a `BitwardenSdk.CipherListViewType`.
-    ///
-    /// Fails (`nil`) when the SDK value is unknown — see `init?(type:)` above for
-    /// rationale.
-    ///
-    /// - Parameter type: The SDK list view type to bridge into the app layer.
-    ///
-    init?(_ type: BitwardenSdk.CipherListViewType) {
+    init(_ type: BitwardenSdk.CipherListViewType) {
         switch type {
         case .card:
             self = .card
@@ -276,12 +245,6 @@ extension CipherType {
             self = .secureNote
         case .sshKey:
             self = .sshKey
-        @unknown default:
-            if NewItemTypesSdkBridge.isBankAccountListViewType(type) {
-                self = .bankAccount
-                return
-            }
-            return nil
         }
     }
 }
@@ -374,12 +337,7 @@ extension BitwardenSdk.Cipher {
             key: model.key,
             name: model.name,
             notes: model.notes,
-            // Fails closed when the app-layer `model.type` is not yet supported by
-            // the SDK (e.g., `.bankAccount` before PM-32009 SDK readiness). The
-            // `.secureNote` fallback is defensive only — the repository / save flow
-            // must reject unsupported types upstream; an `assertionFailure` in
-            // `BitwardenSdk.CipherType.init?(_:)` trips in Debug if reached.
-            type: BitwardenSdk.CipherType(model.type) ?? .secureNote,
+            type: BitwardenSdk.CipherType(model.type),
             login: model.login.map(Login.init),
             identity: model.identity.map(Identity.init),
             card: model.card.map(Card.init),
@@ -424,12 +382,7 @@ extension BitwardenSdk.Cipher {
             key: model.key,
             name: model.name,
             notes: model.notes,
-            // Fails closed when the app-layer `model.type` is not yet supported by
-            // the SDK (e.g., `.bankAccount` before PM-32009 SDK readiness). The
-            // `.secureNote` fallback is defensive only — the repository / save flow
-            // must reject unsupported types upstream; an `assertionFailure` in
-            // `BitwardenSdk.CipherType.init?(_:)` trips in Debug if reached.
-            type: BitwardenSdk.CipherType(model.type) ?? .secureNote,
+            type: BitwardenSdk.CipherType(model.type),
             login: model.login.map(Login.init),
             identity: model.identity.map(Identity.init),
             card: model.card.map(Card.init),
@@ -543,19 +496,7 @@ extension BitwardenSdk.CipherView: @retroactive Identifiable, Fido2UserVerifiabl
 }
 
 extension BitwardenSdk.CipherType {
-    /// Creates a `BitwardenSdk.CipherType` from an app-layer `CipherType`.
-    ///
-    /// Fails (`nil`) when the app-layer value cannot be represented in the SDK yet —
-    /// currently `.bankAccount`, until PM-32009 SDK work lands. This initializer
-    /// **never** silently coerces an unsupported app type to another SDK case; silent
-    /// coercion would cause data loss on save.
-    ///
-    /// Call sites must handle `nil` (fail the save, surface a clear error) rather than
-    /// treat this as infallible.
-    ///
-    /// - Parameter cipherType: The app-layer type to bridge.
-    ///
-    init?(_ cipherType: CipherType) {
+    init(_ cipherType: CipherType) {
         switch cipherType {
         case .login:
             self = .login
@@ -567,26 +508,6 @@ extension BitwardenSdk.CipherType {
             self = .identity
         case .sshKey:
             self = .sshKey
-        case .bankAccount:
-            // Route through the centralized bridge. When the SDK lands support,
-            // `NewItemTypesSdkBridge.sdkCipherTypeForBankAccount()` returns the real
-            // SDK case and this branch succeeds. Until then, it returns `nil` and we
-            // fail closed — no silent coercion.
-            guard let mapped = NewItemTypesSdkBridge.sdkCipherTypeForBankAccount() else {
-                // Tripwire: in Debug builds, surface accidental enabling of the
-                // feature flag before SDK readiness so the divergence is caught in
-                // development rather than producing corrupted saves. Release builds
-                // fail closed via `return nil` immediately below.
-                assertionFailure(
-                    "BitwardenSdk.CipherType.init(_:) called with .bankAccount before the SDK " +
-                        "exposes BankAccount support. Did the newItemTypes feature flag get " +
-                        "enabled ahead of SDK readiness? Fix: keep the flag off until the SDK " +
-                        "dependency is bumped and NewItemTypesSdkBridge.isBankAccountAvailable " +
-                        "is set to true. See PM-32009.",
-                )
-                return nil
-            }
-            self = mapped
         }
     }
 }

BitwardenShared/Core/Vault/Extensions/BitwardenSdk+NewItemTypes.swift

@@ -1,23 +1,12 @@
 /// API model for a bank account cipher.
 ///
-/// Every field defaults to `nil` so callers can use the synthesized memberwise init
-/// conveniently and so the JSON payload minimizes absent fields.
-///
-/// - Important: Instances of this model are **never** to be serialized directly to a
-///   request body reaching the server. All persisted bank account data must pass
-///   through the `BitwardenSdk` encryption path (`CipherView.bankAccount` /
-///   `Cipher.bankAccount` once the SDK exposes those types). This model is strictly an
-///   intermediate representation for JSON round-tripping when the SDK is not yet
-///   available (TODO: PM-32009 Blocked on SDK). See the serialization tripwire in
-///   `BankAccountItemState.apiModel`.
-///
 struct CipherBankAccountModel: Codable, Equatable, Sendable {
     // MARK: Properties
 
-    /// The account number (sensitive; rendered as a hidden field in the UI).
+    /// The account number.
     let accountNumber: String?
 
-    /// The type of the bank account (e.g., checking, savings).
+    /// The type of the bank account.
     let accountType: BankAccountType?
 
     /// The name of the bank.
@@ -35,53 +24,12 @@ struct CipherBankAccountModel: Codable, Equatable, Sendable {
     /// The name on the account.
     let nameOnAccount: String?
 
-    /// The personal identification number (sensitive; rendered as a hidden field in the UI).
+    /// The personal identification number.
     let pin: String?
 
     /// The routing number of the bank.
     let routingNumber: String?
 
     /// The SWIFT / BIC code of the bank.
     let swiftCode: String?
-
-    // MARK: Initialization
-
-    /// Creates a new `CipherBankAccountModel`. All parameters default to `nil` so
-    /// callers can build minimal payloads without listing every field.
-    ///
-    /// - Parameters:
-    ///   - accountNumber: The account number (sensitive).
-    ///   - accountType: The bank account type.
-    ///   - bankName: The name of the bank.
-    ///   - bankPhone: The bank contact phone number.
-    ///   - branchNumber: The branch number of the bank.
-    ///   - iban: The IBAN.
-    ///   - nameOnAccount: The name on the account.
-    ///   - pin: The personal identification number (sensitive).
-    ///   - routingNumber: The routing number.
-    ///   - swiftCode: The SWIFT / BIC code.
-    ///
-    init(
-        accountNumber: String? = nil,
-        accountType: BankAccountType? = nil,
-        bankName: String? = nil,
-        bankPhone: String? = nil,
-        branchNumber: String? = nil,
-        iban: String? = nil,
-        nameOnAccount: String? = nil,
-        pin: String? = nil,
-        routingNumber: String? = nil,
-        swiftCode: String? = nil,
-    ) {
-        self.accountNumber = accountNumber
-        self.accountType = accountType
-        self.bankName = bankName
-        self.bankPhone = bankPhone
-        self.branchNumber = branchNumber
-        self.iban = iban
-        self.nameOnAccount = nameOnAccount
-        self.pin = pin
-        self.routingNumber = routingNumber
-        self.swiftCode = swiftCode
-    }
 }