Skip to content

[PM-34422] [IS] feat: Add card number format grouping#2506

Merged
fedemkr merged 13 commits into
mainfrom
PM-34422/card-number-grouping-UI
May 13, 2026
Merged

[PM-34422] [IS] feat: Add card number format grouping#2506
fedemkr merged 13 commits into
mainfrom
PM-34422/card-number-grouping-UI

Conversation

@fedemkr
Copy link
Copy Markdown
Member

@fedemkr fedemkr commented Mar 30, 2026

🎟️ Tracking

PM-34422

📔 Objective

Add card number format grouping to the cipher add/edit card number fields.

📸 Screenshots

Card number group format

@fedemkr fedemkr requested review from a team and matt-livefront as code owners March 30, 2026 17:10
@fedemkr fedemkr added the innovation Feature work related to Innovation Sprint or BEEEP projects label Mar 30, 2026
@github-actions github-actions Bot added the app:password-manager Bitwarden Password Manager app context label Mar 30, 2026
@fedemkr fedemkr changed the title [PM-34422] [IS] Add card number format grouping [PM-34422] [IS] feat: Add card number format grouping Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 30, 2026

Logo
Checkmarx One – Scan Summary & Detailsddf4fcce-32ff-4c92-b545-8661fd0d9d63

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 30, 2026

Codecov Report

❌ Patch coverage is 98.07692% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 87.35%. Comparing base (4568a40) to head (2559419).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...em/AddEditItem/AddEditCardItem/CardComponent.swift 94.59% 2 Missing ⚠️
...EditItem/AddEditCardItem/AddEditCardItemView.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2506      +/-   ##
==========================================
+ Coverage   87.28%   87.35%   +0.07%     
==========================================
  Files        1908     1920      +12     
  Lines      169827   171086    +1259     
==========================================
+ Hits       148226   149457    +1231     
- Misses      21601    21629      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from PM-33989/card-scanner to main May 8, 2026 18:50
@fedemkr fedemkr dismissed morganzellers-bw’s stale review May 8, 2026 18:50

The base branch was changed.

@fedemkr fedemkr force-pushed the PM-34422/card-number-grouping-UI branch from ac070fd to fc13ff9 Compare May 12, 2026 13:04
@fedemkr fedemkr requested a review from morganzellers-bw May 12, 2026 13:05
@fedemkr fedemkr added the ai-review Request a Claude code review label May 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds brand-aware digit grouping to the Add/Edit card number field, mirroring the existing logic from the clients Angular pipe. Formatting is implemented as a pure function on CardComponent.Brand and consumed through a derived formattedCardNumber property on the state; the action handler now sanitizes input to digits-only before storing, keeping persisted data clean. Test coverage is thorough across brands, length-sensitive cases (Maestro 13/15/16/19, UnionPay 16/19), partial-input greediness, non-digit fallback, brand auto-detection from prefix, and explicit-brand override.

Code Review Details

No findings.

@fedemkr fedemkr merged commit 00e6ff6 into main May 13, 2026
16 checks passed
@fedemkr fedemkr deleted the PM-34422/card-number-grouping-UI branch May 13, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review app:password-manager Bitwarden Password Manager app context innovation Feature work related to Innovation Sprint or BEEEP projects t:feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants