Skip to content

[PM-35398] refactor: Promote ExpandableHeaderView from AuthenticatorShared to BitwardenKit #2582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
SaintPatrck wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −7
Draft

[PM-35398] refactor: Promote ExpandableHeaderView from AuthenticatorShared to BitwardenKit #2582

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8befefd
[PM-35398] refactor: Promote ExpandableHeaderView from AuthenticatorS…
SaintPatrck Apr 24, 2026
f9e4cd5
[PM-35398] refactor: Publicize ExpandableHeaderView and adopt Bitward…
SaintPatrck Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions ...lication/Views/ExpandableHeaderView.swift → ...lication/Views/ExpandableHeaderView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
import BitwardenKit
import BitwardenResources
import SwiftUI

// MARK: - ExpandableHeaderView

/// A wrapper around some content which can be expanded to show the content or collapsed to hide it.
///
struct ExpandableHeaderView<Content: View>: View {
public struct ExpandableHeaderView<Content: View>: View {
// MARK: Properties

/// The accessibility identifier for the button to expand or collapse the content.
Expand All @@ -29,7 +28,7 @@ struct ExpandableHeaderView<Content: View>: View {

// MARK: View

var body: some View {
public var body: some View {
VStack(spacing: 8) {
expandButton

Expand All @@ -52,11 +51,11 @@ struct ExpandableHeaderView<Content: View>: View {
SectionHeaderView("\(title) (\(count))")

SharedAsset.Icons.chevronDown16.swiftUIImage
.imageStyle(.accessoryIcon(scaleWithFont: true))
.imageStyle(.accessoryIcon16(scaleWithFont: true))
.rotationEffect(isExpanded ? Angle(degrees: 180) : .zero)
}
.multilineTextAlignment(.leading)
.foregroundStyle(Asset.Colors.textSecondary.swiftUIColor)
.foregroundStyle(SharedAsset.Colors.textSecondary.swiftUIColor)
}
.accessibilityAddTraits(.isHeader)
.accessibilityIdentifier(buttonAccessibilityIdentifier)
Expand All @@ -74,7 +73,7 @@ struct ExpandableHeaderView<Content: View>: View {
/// - buttonAccessibilityIdentifier: The accessibility identifier for the button to expand or
/// collapse the content.
/// - content: The content that is shown when the section is expanded or hidden otherwise.
init(
public init(
title: String,
count: Int,
buttonAccessibilityIdentifier: String = "ExpandSectionButton",
Expand Down Expand Up @@ -103,6 +102,6 @@ struct ExpandableHeaderView<Content: View>: View {
}
.padding()
.frame(maxHeight: .infinity, alignment: .top)
.background(Asset.Colors.backgroundPrimary.swiftUIColor)
.background(SharedAsset.Colors.backgroundPrimary.swiftUIColor)
}
#endif
Loading