feat: add iOS Safari web extension flow#2595
Draft
2001Y wants to merge 104 commits into
Draft
Conversation
added 30 commits
April 22, 2026 19:11
added 24 commits
April 25, 2026 21:03
|
2001y seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
Thank you for your contribution! We've added this to our internal Community PR board for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
Author
|
Follow-up QA note:
|
added 2 commits
May 2, 2026 00:21
- derive save-login and change-password action-extension routes from page details - add simulator-safe persisted store fallbacks for app extensions - suppress non-actionable simulator appex logging/assertion noise - add regression tests for routing and store fallback behavior
- add a dedicated BitwardenUITests scheme/target for simulator-driven Safari checks - add local login/signup/change-password fixture pages and Maestro smoke flows - document the fixture-based Safari extension testing loop - cover live save, fill, change-password, and generate-follow-up flows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Changes
BitwardenSafariWebExtensiontarget scaffold, manifest resources, and native handler/bridge wiringpageDetails.appexerror assertions/noise that blocked live QABitwardenUITeststarget/scheme plus fixture-driven simulator smoke coverageTest Plan
node BitwardenSafariWebExtension/Application/Support/content.node-test.jsnode BitwardenSafariWebExtension/Application/Support/background.node-test.jsxcodebuild test -disableAutomaticPackageResolution -project Bitwarden.xcodeproj -scheme Bitwarden -destination 'platform=iOS Simulator,name=iPhone 17 Pro,OS=26.4.1' -only-testing:BitwardenSafariWebExtensionTests -only-testing:BitwardenSharedTests/SafariExtensionRequestProcessorTests -only-testing:BitwardenSharedTests/SafariExtensionResponseTests -only-testing:BitwardenSharedTests/SafariExtensionBridgeCodecTests -only-testing:BitwardenSharedTests/SafariExtensionStateTests -only-testing:BitwardenSharedTests/SafariExtensionProcessorTests -only-testing:BitwardenSharedTests/SettingsCoordinatorTests -only-testing:BitwardenSharedViewInspectorTests/SafariExtensionViewTests CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NOxcodebuild build -disableAutomaticPackageResolution -project Bitwarden.xcodeproj -scheme BitwardenSafariWebExtension -destination 'generic/platform=iOS Simulator' CODE_SIGNING_ALLOWED=NO COMPILER_INDEX_STORE_ENABLE=NOxcodebuild test -project Bitwarden.xcodeproj -scheme Bitwarden -destination 'platform=iOS Simulator,name=iPhone 17 Pro,OS=26.4.1' -only-testing:BitwardenSharedTests/ActionExtensionHelperTests -only-testing:BitwardenSharedTests/DataStoreTests -only-testing:BitwardenKitTests/ErrorNetworkingTests COMPILER_INDEX_STORE_ENABLE=NOiPhone 17 Pro (iOS 26.4.1)LoginMasterPasswordEntrywithpassword.2001y.devDocs/safari-extension-dev-fixtures/signup.htmlNew loginfollow-upDocs/safari-extension-dev-fixtures/login.htmlDocs/safari-extension-dev-fixtures/change-password.htmlScreenshots / Examples
Notes for Reviewers
.appexCore Data fallback + non-loggable assertion suppression), not a product-facing entitlement change