Skip to content

[bre-1881] ios CI build fix#2614

Merged
aj-bw merged 14 commits into
mainfrom
bre-1881/test-ios-build-fix
May 11, 2026
Merged

[bre-1881] ios CI build fix#2614
aj-bw merged 14 commits into
mainfrom
bre-1881/test-ios-build-fix

Conversation

@aj-bw
Copy link
Copy Markdown
Member

@aj-bw aj-bw commented May 5, 2026

🎟️ Tracking

bre-1881

📔 Objective

relevant deploy PR https://github.com/bitwarden/deploy/pull/92

Summary

Fixes broken TestFlight uploads caused by a stale appstoreconnect-fastlane.json credential in Azure blob storage, and adds a cross-repo changelog trigger that sets the TestFlight "What to Test" notes after each successful upload.

  • Removes the blob-stored Fastlane credential and replaces it with a direct AKV key fetch from gh-ios (APP-STORE-CONNECT-AUTH-ID, APP-STORE-CONNECT-AUTH-KEY, APP-STORE-CONNECT-TEAM-ISSUER)
  • Replaces bundle exec fastlane upload_build with xcrun altool --upload-app
  • Adds a post-upload cross-repo trigger to bitwarden/deploy that dispatches a changelog workflow using an App Manager key, necessary because the Developer-role key used for upload cannot write betaBuildLocalizations
  • Fixes _BUILD_VARIANT comparison typo (bwpm-prodbwpm_prod)
  • Anchors the CI run URL at the top of the changelog so it's never lost to truncation
  • Updates ci-bwpm.yml and ci-bwa.yml to reference _build-any.yml via local path instead of @main, so workflow changes on feature branches are actually exercised in CI

Test plan

@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.27%. Comparing base (b99138c) to head (5c456c2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2614      +/-   ##
==========================================
- Coverage   87.31%   86.27%   -1.04%     
==========================================
  Files        1912     2137     +225     
  Lines      170379   184896   +14517     
==========================================
+ Hits       148759   159521   +10762     
- Misses      21620    25375    +3755     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aj-bw aj-bw marked this pull request as ready for review May 6, 2026 01:26
@aj-bw aj-bw requested review from a team and matt-livefront as code owners May 6, 2026 01:26
@aj-bw aj-bw changed the title [bre-1881] test ios build fix [bre-1881] ios CI build fix May 6, 2026
@vvolkgang
Copy link
Copy Markdown
Member

@aj-bw good find, such an unfortunate timing. Was going to trigger a full CI run but noticed you were already on it, triggered one for BWA:

  1. BWPM - https://github.com/bitwarden/ios/actions/runs/25436452277
  2. BWA - https://github.com/bitwarden/ios/actions/runs/25436825890

matt-livefront
matt-livefront previously approved these changes May 7, 2026
Copy link
Copy Markdown
Collaborator

@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@aj-bw aj-bw requested a review from a team as a code owner May 8, 2026 18:05
Comment thread .github/workflows/_build-any.yml
Comment thread .github/workflows/ci-bwpm.yml Outdated
Comment thread .github/workflows/_build-any.yml Outdated
Comment thread .github/workflows/_build-any.yml Outdated
Comment thread .github/workflows/_build-any.yml Outdated
Comment thread .github/workflows/_build-any.yml
@aj-bw aj-bw merged commit d61c576 into main May 11, 2026
18 checks passed
@aj-bw aj-bw deleted the bre-1881/test-ios-build-fix branch May 11, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants