[PM-36622] feat: add premium upgrade complete modal UI#2618
Merged
Conversation
Adds a new success modal shown after the Stripe payment flow completes. The modal displays the success icon, "Upgraded to Premium" title, a description, a primary "Learn more" button linking to the premium help page, and a secondary "Close" button. - PremiumUpgradeCompleteView, Processor, Action (stateless modal) - BillingRoute.premiumUpgradeComplete + coordinator navigation - premium-success illustration asset (placeholder PDF, replace with designer asset from PM-36622 Jira attachment) - ExternalLinksConstants.learnMoreAboutPremium URL constant - Localization string: UpgradedToPremiumDescriptionLong
github-actions
Bot
added
app:password-manager
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2618 +/- ##
==========================================
- Coverage 87.22% 86.26% -0.97%
==========================================
Files 1899 2130 +231
Lines 168083 183854 +15771
==========================================
+ Hits 146612 158601 +11989
- Misses 21471 25253 +3782 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “Upgraded to Premium” success modal to the Billing flow, intended to be shown after completing the Stripe payment process (UI only; wiring handled elsewhere).
Changes:
- Introduces
PremiumUpgradeCompleteView(illustration, title/description, “Learn more” external link button, and “Close” button) plus unit/UI tests. - Adds
BillingRoute.premiumUpgradeCompleteand coordinator navigation to present the new modal. - Adds supporting resources: a new illustration asset, a new external help URL constant, and a new localization string.
Reviewed changes
Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| BitwardenShared/UI/Platform/Application/Support/Images.xcassets/Images/Illustrations/premium-success.imageset/Contents.json | Registers the new “premium-success” illustration asset. |
| BitwardenShared/UI/Billing/PremiumUpgradeComplete/PremiumUpgradeCompleteView.swift | Implements the Premium upgrade success modal UI (illustration + actions). |
| BitwardenShared/UI/Billing/PremiumUpgradeComplete/PremiumUpgradeCompleteAction.swift | Defines the action(s) for the modal (close). |
| BitwardenShared/UI/Billing/PremiumUpgradeComplete/PremiumUpgradeCompleteProcessor.swift | Handles modal actions and routes dismissal through the coordinator. |
| BitwardenShared/UI/Billing/PremiumUpgradeComplete/PremiumUpgradeCompleteProcessorTests.swift | Adds processor-level test coverage for dismissal routing. |
| BitwardenShared/UI/Billing/PremiumUpgradeComplete/PremiumUpgradeCompleteView+ViewInspectorTests.swift | Adds ViewInspector tests validating key UI elements and close behavior. |
| BitwardenShared/UI/Billing/PremiumUpgradeComplete/PremiumUpgradeCompleteView+SnapshotTests.swift | Adds (currently disabled) snapshot coverage for the new modal UI. |
| BitwardenShared/UI/Billing/BillingRoute.swift | Adds a new route for the premium upgrade complete modal. |
| BitwardenShared/UI/Billing/BillingCoordinator.swift | Presents the new modal when navigating to the new billing route. |
| BitwardenShared/UI/Billing/BillingCoordinatorTests.swift | Adds coordinator test coverage for presenting the new modal route. |
| BitwardenShared/Core/Platform/Utilities/ExternalLinksConstants.swift | Adds a help-center URL constant used by the “Learn more” button. |
| BitwardenResources/Localizations/en.lproj/Localizable.strings | Adds the new English description string for the modal. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 |
Comment on lines
1076
to
1079
| "YourUpgradeIsBeingProcessedDescriptionLong" = "Your upgrade is being processed. You'll remain on the free plan until it's complete. Sync now to check, or continue and it will update automatically."; | ||
| "UpgradedToPremium" = "Upgraded to Premium"; | ||
| "UpgradedToPremiumDescriptionLong" = "You now have access to advanced security features. Learn more about what's included with Premium."; | ||
| "ViewPlanDetails" = "View plan details"; |
The premiumCheckoutStatusPublisher_lateSubscriberReceivesPendingStatus test requires two 300ms debounce cycles (~660ms total) which exceeded the CI per-test limit of 1 second under load. Annotate with a 5s limit.
…illing test" This reverts commit 34f7f6c.
matt-livefront
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-36622
📔 Objective
Adds the new "Upgraded to Premium" success modal shown after a user completes the Stripe payment flow. Includes the illustrated success icon, title, description, a primary "Learn more" button (opens the premium plans help page), and a secondary "Close" button.
This PR only covers UI creation. Wiring this modal into the post-payment flow is handled in PM-36623.
📸 Screenshots