Skip to content

[PM-36946] ci: Increase per-test timeout from 1s to 2s#2623

Merged
KatherineInCode merged 3 commits into
mainfrom
pm-36946/increase-test-timeout
May 11, 2026
Merged

[PM-36946] ci: Increase per-test timeout from 1s to 2s#2623
KatherineInCode merged 3 commits into
mainfrom
pm-36946/increase-test-timeout

Conversation

@KatherineInCode
Copy link
Copy Markdown
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36946

📔 Objective

Increases the -maximum-test-execution-time-allowance xcodebuild flag from 1 second to 2 seconds in both test.yml and test-bwa.yml.

Parallelized Swift Testing tests can exceed the 1s limit under system load caused by the parallelization itself, resulting in spurious CI failures. Raising the limit to 2s gives those tests headroom without masking genuinely slow tests. Parallelization is a net win for overall suite speed, so the right fix is a slightly looser timeout rather than reverting parallelization.

Parallelized Swift Testing tests can exceed 1s under system load from
parallelization itself, causing spurious CI failures. 2s gives headroom
without masking genuinely slow tests.
@KatherineInCode KatherineInCode added the ai-review-vnext Request a Claude code review using the vNext workflow label May 8, 2026
@github-actions github-actions Bot added the t:ci Change Type - Updates to automated workflows label May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR raises the xcodebuild -maximum-test-execution-time-allowance flag from 1 second to 2 seconds in both .github/workflows/test.yml and .github/workflows/test-bwa.yml. The change is symmetric across both workflows, the rationale (parallelization-induced contention causing spurious timeouts on otherwise-correct tests) is clearly explained in the PR description, and the new 2s ceiling still preserves the intent of catching genuinely slow tests. No security, correctness, or breaking-change concerns identified.

Code Review Details

No findings.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.23%. Comparing base (e795e9e) to head (00f8421).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2623      +/-   ##
==========================================
- Coverage   87.30%   86.23%   -1.07%     
==========================================
  Files        1900     2128     +228     
  Lines      169245   184231   +14986     
==========================================
+ Hits       147760   158874   +11114     
- Misses      21485    25357    +3872     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode KatherineInCode marked this pull request as ready for review May 8, 2026 17:41
@KatherineInCode KatherineInCode requested a review from a team as a code owner May 8, 2026 17:41
@KatherineInCode KatherineInCode merged commit b99138c into main May 11, 2026
19 of 20 checks passed
@KatherineInCode KatherineInCode deleted the pm-36946/increase-test-timeout branch May 11, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow t:ci Change Type - Updates to automated workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants