Skip to content

XUnit.v3 Upgrade#6596

Draft
justindbaur wants to merge 11 commits into
mainfrom
xunit-v3-full-upgrade
Draft

XUnit.v3 Upgrade#6596
justindbaur wants to merge 11 commits into
mainfrom
xunit-v3-full-upgrade

Conversation

@justindbaur
Copy link
Copy Markdown
Member

@justindbaur justindbaur commented Nov 18, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-19126

📔 Objective

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2025

Logo
Checkmarx One – Scan Summary & Details8f60abef-9242-461c-a950-02c3000d95d2

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 13.30%. Comparing base (5ac8536) to head (8b21b1d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6596       +/-   ##
===========================================
- Coverage   53.95%   13.30%   -40.65%     
===========================================
  Files        1922     1151      -771     
  Lines       85241    50023    -35218     
  Branches     7623     4305     -3318     
===========================================
- Hits        45995     6658    -39337     
- Misses      37480    43233     +5753     
+ Partials     1766      132     -1634     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant