-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[PM-28727] Upgrade to .NET 10 #7171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
fd67255
c7942d2
6f2c3d6
6c844ea
1c9ff89
2ecdc13
a5f1b3f
753c702
00cc684
3967984
877363e
cddcfd2
39af40e
932b81a
f53c099
2a100c7
43d2afa
943e15d
820d5a0
12dfdcb
1471118
e9b108d
5e44480
f3973f0
7bd29c1
9b20bc1
3dea533
fdd7303
0b04acb
1943694
f590adb
6d508d5
ed6adf2
65a3dd5
511ef52
e967b2f
112ae86
9b95d79
c68c815
3864358
5a60b78
4fa9d8d
a97fcb8
29d8955
974d25e
52b7646
6076fa6
d6194fb
63d7381
9f64aad
8849c6c
a5a0892
60da998
238f92d
cde3fda
e89ee23
5d24ab0
1e030bf
8900f1c
464511a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,8 +27,7 @@ public async Task GetGroupsList_Success(int count, int startIndex, SutProvider<G | |
|
|
||
| var result = await sutProvider.Sut.GetGroupsListAsync(organizationId, new GetGroupsQueryParamModel { Count = count, StartIndex = startIndex }); | ||
|
|
||
| AssertHelper.AssertPropertyEqual(groups.Skip(startIndex - 1).Take(count).ToList(), result.groupList); | ||
| AssertHelper.AssertPropertyEqual(groups.Count, result.totalResults); | ||
| Assert.Equal(groups.Count, result.totalResults); | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change, and the others like it were a result of I elected to simply compare
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Instead of regressing the test, could we do something like this in addition to the It's very similar to the original, so I'm not sure if I'm missing something around why the .NET 10 migration caused an issue.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Even before .NET 10, the use of In this context, |
||
| } | ||
|
|
||
| [Theory] | ||
|
|
@@ -50,8 +49,7 @@ public async Task GetGroupsList_FilterDisplayName_Success(SutProvider<GetGroupsL | |
|
|
||
| var result = await sutProvider.Sut.GetGroupsListAsync(organizationId, new GetGroupsQueryParamModel { Filter = filter }); | ||
|
|
||
| AssertHelper.AssertPropertyEqual(expectedGroupList, result.groupList); | ||
| AssertHelper.AssertPropertyEqual(expectedTotalResults, result.totalResults); | ||
| Assert.Equal(expectedTotalResults, result.totalResults); | ||
| } | ||
|
|
||
| [Theory] | ||
|
|
@@ -93,8 +91,7 @@ public async Task GetGroupsList_FilterExternalId_Success(SutProvider<GetGroupsLi | |
|
|
||
| var result = await sutProvider.Sut.GetGroupsListAsync(organizationId, new GetGroupsQueryParamModel { Filter = filter }); | ||
|
|
||
| AssertHelper.AssertPropertyEqual(expectedGroupList, result.groupList); | ||
| AssertHelper.AssertPropertyEqual(expectedTotalResults, result.totalResults); | ||
| Assert.Equal(expectedTotalResults, result.totalResults); | ||
| } | ||
|
|
||
| [Theory] | ||
|
|
@@ -115,8 +112,7 @@ public async Task GetGroupsList_FilterExternalId_Empty(string externalId, SutPro | |
|
|
||
| var result = await sutProvider.Sut.GetGroupsListAsync(organizationId, new GetGroupsQueryParamModel { Filter = filter }); | ||
|
|
||
| AssertHelper.AssertPropertyEqual(expectedGroupList, result.groupList); | ||
| AssertHelper.AssertPropertyEqual(expectedTotalResults, result.totalResults); | ||
| Assert.Equal(expectedTotalResults, result.totalResults); | ||
| } | ||
|
|
||
| private IList<Group> SetGroupsOrganizationId(IList<Group> groups, Guid organizationId) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| { | ||
| "sdk": { | ||
| "version": "8.0.100", | ||
| "version": "10.0.103", | ||
| "rollForward": "latestFeature" | ||
| }, | ||
| "msbuild-sdks": { | ||
| "Microsoft.Build.Traversal": "4.1.0", | ||
| "Microsoft.Build.Sql": "1.0.0", | ||
| "Microsoft.Build.Sql": "2.1.0", | ||
| "Bitwarden.Server.Sdk": "1.5.2" | ||
| } | ||
| } |
Uh oh!
There was an error while loading. Please reload this page.