Conversation
…nizationUserRepository.
Contributor
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds Code Review DetailsNo findings. The code is clean and follows established patterns. Previous reviewer feedback (removing "And" from stored procedure names, using |
JimmyVo16
commented
Apr 6, 2026
| { | ||
| var dbContext = GetDatabaseContext(scope); | ||
| var view = new OrganizationUserOrganizationDetailsViewQuery(); | ||
| var t = await (view.Run(dbContext)).ToArrayAsync(); |
Contributor
Author
There was a problem hiding this comment.
This isn’t related to my PR, but it’s dead code and not being used. It was introduced about five years ago. Since AC owns this code now, I think we should remove it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7399 +/- ##
==========================================
+ Coverage 58.54% 62.69% +4.15%
==========================================
Files 2063 2063
Lines 91186 91207 +21
Branches 8123 8123
==========================================
+ Hits 53382 57185 +3803
+ Misses 35894 32030 -3864
- Partials 1910 1992 +82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
New Issues (124)Checkmarx found the following issues in this Pull Request
|
Contributor
Author
|
I'm looking into Checkmarx. I feel like it's a false positive since I'm using an established pattern. |
Contributor
Author
|
Talked to Matt Andreko about Checkmarx, and this is a false positive. We’re looking into moving to a new system in the near future. |
mkincaid-bw
reviewed
Apr 7, 2026
| @@ -0,0 +1,14 @@ | |||
| CREATE PROCEDURE [dbo].[OrganizationUserOrganizationDetails_ReadConfirmedAndAcceptedByUserId] | |||
Contributor
There was a problem hiding this comment.
We want to avoid using And in proc names (see note: "Do not use And between parameter names in procedure names"):
https://contributing.bitwarden.com/contributing/code-style/sql/#common-examples
mkincaid-bw
reviewed
Apr 7, 2026
| @@ -0,0 +1,20 @@ | |||
| IF OBJECT_ID('[dbo].[OrganizationUserOrganizationDetails_ReadConfirmedAndAcceptedByUserId]') IS NOT NULL | |||
Contributor
There was a problem hiding this comment.
This should use CREATE OR ALTER instead of DROP/CREATE
https://contributing.bitwarden.com/contributing/code-style/sql/#creating-or-modifying-a-function-or-stored-procedure
JimmyVo16
changed the title
|
eliykat
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34147
📔 Objective
GetManyConfirmedAcceptedDetailsByUserAsync(Guid userId)to theIOrganizationUserRepositoryinterface📸 Screenshots
Migration was successful.