[PM-32073] - Added Bulk Get Org Ability#7476
Conversation
Bitwarden Claude Code ReviewOverall Assessment: APPROVE This PR adds Code Review DetailsNo findings. The implementation follows established caching and feature-flag patterns in the codebase. Cache key simplification from |
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7476 +/- ##
=======================================
Coverage 59.08% 59.08%
=======================================
Files 2078 2078
Lines 91488 91495 +7
Branches 8135 8136 +1
=======================================
+ Hits 54053 54062 +9
+ Misses 35507 35503 -4
- Partials 1928 1930 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JaredScar
left a comment
There was a problem hiding this comment.
Looks good to me, nice work fellow Jared
There was a problem hiding this comment.
Nit (non-blocker): There will be a provider cache here, so it’ll probably make more sense to add “org” to this cache name. That said, we have a ticket to remove this whole class in the near future, and it’s only a local variable, so I’ll leave it up to you.
# Conflicts: # src/Core/Services/Implementations/FeatureRoutedCacheService.cs
|





🎟️ Tracking
PM-32073
📔 Objective
This adds the bulk get implementation of the org ability from the extended cache (FusionCache). It also cleans up some test files.