PM-33527 adding background job to clean up#7517
Open
prograhamming wants to merge 17 commits into
Open
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
…:bitwarden/server into dirt/pm-33527/remove-orphaned-event-logs
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7517 +/- ##
==========================================
- Coverage 59.84% 59.78% -0.06%
==========================================
Files 2120 2126 +6
Lines 93168 93424 +256
Branches 8264 8277 +13
==========================================
+ Hits 55752 55853 +101
- Misses 35441 35595 +154
- Partials 1975 1976 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Contributor
|
Code looks good, waiting to approve 'till red becomes more green and it forces me to re-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-33527
📔 Objective
In all instances when we delete a cipher/user/org and sends and event logs are deleted from the DB, make sure that artifacts are also deleted from storage. We need to delete event log files from Azure Table Storage Event data storage otherwise we have data retention issues that conflict with GDPR.
Database PR is here. DB tests will fail until it is merged in.
📸 Screenshots