Implement master password policy requirement#7537
Conversation
|
The unrelated files are getting hit by |
djsmith85
left a comment
There was a problem hiding this comment.
Changes in util/Setup are unrelated to this PR. Did they get added due to some IDE formatting?
They are getting hit by |
jrmccannon
left a comment
There was a problem hiding this comment.
Looks good. I assume build errors will go away once package upgrades are completed.
|
This will be fixed up and addressed as a separate tech debt ticket. Moving back to draft in the meantime. |
|
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7537 +/- ##
==========================================
+ Coverage 59.26% 59.30% +0.04%
==========================================
Files 2082 2083 +1
Lines 92060 92071 +11
Branches 8181 8180 -1
==========================================
+ Hits 54556 54604 +48
+ Misses 35563 35526 -37
Partials 1941 1941 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* implement master password policy requirement * revert unrelated chagned files * fix aggregate pattern in factory, move away from ctor * remove admin/owner exemption * revert mp exemption in policyService




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-35926
📔 Objective
This pr implements the
MasterPasswordPolicyRequirementusing theIPolicyRequirementpattern:MasterPasswordPolicyRequirement: a new policy requirement class that aggregates enforced master password options (min length, complexity, character requirements) across all applicable org policies, no exempt rolesMasterPasswordPolicyRequirementFactoryto create the requirement and registers it in DI.PolicyServiceto useIPolicyRequirementQueryinstead of directly queryingIPolicyRepository, migrating master password enforcement to the new requirements framework.PolicyServiceTests.📸 Screenshots