Skip to content

[PM-36047] Add tech-leads group as owners of the CODEOWNERS file#7562

Merged
coltonhurst merged 1 commit intomainfrom
dn/pm-36047
May 4, 2026
Merged

[PM-36047] Add tech-leads group as owners of the CODEOWNERS file#7562
coltonhurst merged 1 commit intomainfrom
dn/pm-36047

Conversation

@coltonhurst
Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-36047

📔 Objective

For some existing repositories, there is no owner for the CODEOWNERS file itself. This presents a couple of concerns. The main initial concern is that a team’s ownership can change without them knowing or being approvers of the change.

This could be fixed in multiple ways, but two were discussed:

  1. CODEOWNERS changes require approval from all teams whose ownership is changing. This is the better solution, but GitHub doesn’t seem to provide this capability. Something custom would have to be created, so this option is more effort.
  2. CODEOWNERS changes require approval from the Tech Lead group. This is a less ideal solution compared to #1, but it should help provide more approval from the tech lead owners of files, and give them notifications on any changes.

For now, this change goes route #2. We aim to apply these changes only on monorepos. Team specific repositories shouldn't have this change.

@coltonhurst coltonhurst self-assigned this Apr 29, 2026
@sonarqubecloud
Copy link
Copy Markdown

@coltonhurst coltonhurst marked this pull request as ready for review April 29, 2026 15:43
@coltonhurst coltonhurst requested a review from theMickster April 29, 2026 15:44
@github-actions
Copy link
Copy Markdown
Contributor

Logo
Checkmarx One – Scan Summary & Details9a363e33-c744-4fbb-958c-6d16084b7c39

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.36%. Comparing base (c281161) to head (62a6020).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7562      +/-   ##
==========================================
- Coverage   63.81%   59.36%   -4.46%     
==========================================
  Files        2087     2087              
  Lines       92262    92262              
  Branches     8200     8200              
==========================================
- Hits        58880    54769    -4111     
- Misses      31356    35554    +4198     
+ Partials     2026     1939      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coltonhurst coltonhurst merged commit a523128 into main May 4, 2026
45 checks passed
@coltonhurst coltonhurst deleted the dn/pm-36047 branch May 4, 2026 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants