Skip to content

[PM-12469] Move remaining Admin Password Reset code to AC team#7680

Open
eliykat wants to merge 1 commit into
mainfrom
ac/pm-12469/server-admin-password-reset
Open

[PM-12469] Move remaining Admin Password Reset code to AC team#7680
eliykat wants to merge 1 commit into
mainfrom
ac/pm-12469/server-admin-password-reset

Conversation

@eliykat
Copy link
Copy Markdown
Member

@eliykat eliykat commented May 20, 2026

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12469

📔 Objective

Moves the remaining Admin Password Reset files into the AdminConsole team's folder structure (no behavior changes):

  • OrganizationUserResetPasswordRequestModelApi/AdminConsole/Models/Request/Organizations/
  • AdminResetPasswordViewModelCore/AdminConsole/Models/Mail/
  • OrganizationUser_ReadManyAccountRecoveryDetailsByOrganizationUserIds.sqlSql/dbo/AdminConsole/Stored Procedures/

Updates affected using/namespace references accordingly.

@eliykat eliykat added the ai-review Request a Claude code review label May 20, 2026
@eliykat eliykat changed the title [PM-12469] refactor: Move remaining Admin Password Reset code to AC team [PM-12469] Move remaining Admin Password Reset code to AC team May 20, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Pure file-move refactor relocating the remaining Admin Password Reset assets into the AdminConsole team's folder structure. The request model, mail view model, and stored procedure are renamed with namespaces updated, and the four dependent files (OrganizationUsersController, UpdateTempPasswordRequestModel, and the two test files) have their using directives updated accordingly. HandlebarsMailService already references the new Bit.Core.AdminConsole.Models.Mail namespace, and Sql.sqlproj picks up the relocated stored procedure automatically through globbing. No behavioral changes were introduced.

Code Review Details

No findings.

@eliykat eliykat marked this pull request as ready for review May 20, 2026 05:57
@eliykat eliykat requested review from a team as code owners May 20, 2026 05:57
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.53%. Comparing base (543afdc) to head (9e8648a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7680      +/-   ##
==========================================
+ Coverage   60.07%   64.53%   +4.46%     
==========================================
  Files        2132     2132              
  Lines       93886    93886              
  Branches     8337     8337              
==========================================
+ Hits        56399    60593    +4194     
+ Misses      35503    31218    -4285     
- Partials     1984     2075      +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat eliykat enabled auto-merge (squash) May 20, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants