[PM-25691] Create OrganizationUpdateCollectionManagementCommand command#7682
Open
r-tome wants to merge 5 commits into
Open
[PM-25691] Create OrganizationUpdateCollectionManagementCommand command#7682r-tome wants to merge 5 commits into
r-tome wants to merge 5 commits into
Conversation
…terface for managing organization collection settings * Add UpdateCollectionManagementSettingsCommand to handle updates to organization collection management settings. * Create IUpdateCollectionManagementSettingsCommand interface to define the update method. * Implement unit tests for UpdateCollectionManagementSettingsCommand to verify event logging and exception handling.
* Register IUpdateCollectionManagementSettingsCommand and its implementation, UpdateCollectionManagementSettingsCommand, in the service collection for managing organization collection settings.
…nagementCommand * Added IOrganizationUpdateCollectionManagementCommand to the OrganizationsController for managing collection settings updates. * Updated the constructor to inject the new command and modified the PutCollectionManagement method to utilize it. * Adjusted unit tests to reflect the changes in the command used for updating collection management settings.
…eCollectionManagementSettingsAsync method * Removed the UpdateCollectionManagementSettingsAsync method from IOrganizationService and its implementation in OrganizationService. * Cleaned up unused usings related to collection management settings in both service files. * Updated unit tests to reflect the removal of the collection management settings update functionality.
Contributor
|
Claude Code is reviewing this pull request... If this comment does not update with results, check the Actions log. |
r-tome
changed the title
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7682 +/- ##
=======================================
Coverage 60.07% 60.08%
=======================================
Files 2132 2133 +1
Lines 93904 93919 +15
Branches 8341 8341
=======================================
+ Hits 56417 56432 +15
Misses 35503 35503
Partials 1984 1984 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25691
📔 Objective
Lift and shift the method
UpdateCollectionManagementSettingsAsyncfromOrganizationServiceinto a new command.