[PM-31191] New Argon2id configuration into prelogin#7708
Open
mzieniukbw wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7708 +/- ##
==========================================
- Coverage 65.01% 60.56% -4.45%
==========================================
Files 2145 2145
Lines 95028 95036 +8
Branches 8504 8504
==========================================
- Hits 61781 57561 -4220
- Misses 31126 35445 +4319
+ Partials 2121 2030 -91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ike-kottlowski
previously approved these changes
May 27, 2026
# Conflicts: # src/Core/Constants.cs # src/Identity/Controllers/AccountsController.cs
|
quexten
approved these changes
May 28, 2026
ike-kottlowski
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31191
Related: #7709
📔 Objective
New Argon2id defaults:
Added to prelogin.
Old one retained.
Added comments and tests to make sure change to Kdf defaults would result in test failure.
📸 Screenshots