[PM-16095] feat: Enhance provider seat limit validation messages#7980
[PM-16095] feat: Enhance provider seat limit validation messages#7980JaredScar wants to merge 1 commit into
Conversation
Updated the InviteUsersPasswordManagerValidator to include seat count in validation results. Modified ProviderResellerSeatLimitError to accept seat count and adjusted related validation logic in InvitingUserOrganizationProviderValidator. Updated OrganizationService to reflect seat limits in error messages and adjusted corresponding tests for consistency.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed this bugfix that enhances provider reseller seat-limit validation messages to include the explicit seat count. Changes span Code Review DetailsNo blocking findings. The interpolated |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7980 +/- ##
==========================================
+ Coverage 62.03% 62.05% +0.02%
==========================================
Files 2276 2277 +1
Lines 99404 99455 +51
Branches 8980 8983 +3
==========================================
+ Hits 61667 61719 +52
+ Misses 35565 35563 -2
- Partials 2172 2173 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eliykat
left a comment
There was a problem hiding this comment.
Looks good as far as server changes go, but I would assume that a user would never see this in practice because it'll be caught by the front-end validation first. If that's the case, it would be the front-end (inline?) error message that needs updating. If not, then I wonder if we've missed something with the current front-end validation. Or maybe I'm misunderstanding and this is a gap that is intentionally handled by the server - let me know.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16095
📔 Objective
Fixes error message for reseller orgs to say how many seats they have in the error message explicitly
📸 Screenshots