Skip to content

Fix failing test in test/samples/test_readme_examples.gd #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Curtis-Barnhart wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix failing test in test/samples/test_readme_examples.gd #821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2733752
updated invalid doubling approach using paths to scripts instead of l…
Curtis-Barnhart Mar 10, 2026
dcd23bb
fixed assert in test_illustrate_yield that was too stringent
Curtis-Barnhart Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions test/samples/test_readme_examples.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ func test_illustrate_yield():
# While the yield happens, the node should move
await yield_for(2)
assert_gt(moving_node.get_position().x, 0)
assert_between(moving_node.get_position().x, 3.9, 4, 'it should move almost 4 whatevers at speed 2')
assert_between(moving_node.get_position().x, 3.9, 4.1, 'it should move almost 4 whatevers at speed 2')


# ------------------------------------------------------------------------------
Expand Down Expand Up @@ -543,7 +543,7 @@ func test_assert_is():
func test_assert_called():
var DOUBLE_ME_PATH = 'res://test/resources/doubler_test_objects/double_extends_node2d.gd'

var doubled = double(DOUBLE_ME_PATH).new()
var doubled = double(load(DOUBLE_ME_PATH)).new()
doubled.set_value(4)
doubled.set_value(5)
doubled.has_two_params_one_default('a')
Expand Down Expand Up @@ -574,7 +574,7 @@ func test_assert_called():
func test_assert_call_count():
var DOUBLE_ME_PATH = 'res://test/resources/doubler_test_objects/double_extends_node2d.gd'

var doubled = double(DOUBLE_ME_PATH).new()
var doubled = double(load(DOUBLE_ME_PATH)).new()
doubled.set_value(4)
doubled.set_value(5)
doubled.has_two_params_one_default('a')
Expand Down Expand Up @@ -602,7 +602,7 @@ func test_assert_call_count():
func test_get_call_parameters():
var DOUBLE_ME_PATH = 'res://test/resources/doubler_test_objects/double_extends_node2d.gd'

var doubled = double(DOUBLE_ME_PATH).new()
var doubled = double(load(DOUBLE_ME_PATH)).new()
doubled.set_value(5)
doubled.has_two_params_one_default('a')
doubled.has_two_params_one_default('x', 'y')
Expand Down Expand Up @@ -768,5 +768,3 @@ func test_assert_setget():

# assert_setget(HealthBar, 'label') # FAIL => setter or getter has to be specified
# assert_setget(HealthBar, 'label', true) # FAIL => setter does not exist