Skip to content

Commit eb48438

Browse files
bkaradzic-microsoftbkaradzic
bkaradzic-microsoft
and
bkaradzic
authored
Fix other reason comments. (BabylonJS#1692)
Co-authored-by: Branimir Karadzic <branimirkaradzic@gmail.com>
1 parent 06a5a0e commit eb48438

1 file changed

Lines changed: 21 additions & 21 deletions

File tree

‎Apps/Playground/Scripts/config.json‎

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1208,7 +1208,7 @@
12081208
"playgroundId": "#1VGT5D#2",
12091209
"renderCount": 50,
12101210
"excludeFromAutomaticTesting": true,
1211-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
1211+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
12121212
"referenceImage": "particle-helper.png"
12131213
},
12141214
{
@@ -1660,7 +1660,7 @@
16601660
"renderCount": 100,
16611661
"referenceImage": "particles.png",
16621662
"excludeFromAutomaticTesting": true,
1663-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
1663+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
16641664
},
16651665
{
16661666
"title": "PBRMetallicRoughnessMaterial",
@@ -2441,7 +2441,7 @@
24412441
"playgroundId": "#544N0Q#67",
24422442
"renderCount": 120,
24432443
"excludeFromAutomaticTesting": true,
2444-
"reason": "After #1569 stride fix, hits bgfx 'Invalid texture attachment' frame buffer validation (exit 1); needs separate investigation.",
2444+
"reason": "After #1691 stride fix, hits bgfx 'Invalid texture attachment' frame buffer validation (exit 1); needs separate investigation.",
24452445
"referenceImage": "fluidParticleSystem.png"
24462446
},
24472447
{
@@ -2863,7 +2863,7 @@
28632863
"playgroundId": "#2441BU#1",
28642864
"renderCount": 20,
28652865
"excludeFromAutomaticTesting": true,
2866-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
2866+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
28672867
"referenceImage": "halo-particle-system.png"
28682868
},
28692869
{
@@ -2879,7 +2879,7 @@
28792879
"playgroundId": "#DMLLV2",
28802880
"renderCount": 5,
28812881
"excludeFromAutomaticTesting": true,
2882-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
2882+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
28832883
"referenceImage": "particle-system-with-custom-nme-shader.png"
28842884
},
28852885
{
@@ -4292,7 +4292,7 @@
42924292
"renderCount": 120,
42934293
"referenceImage": "NME-Particles-with-PositionW.png",
42944294
"excludeFromAutomaticTesting": true,
4295-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4295+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
42964296
},
42974297
{
42984298
"title": "Particles - Basic Properties - Size",
@@ -4312,7 +4312,7 @@
43124312
"renderCount": 120,
43134313
"referenceImage": "particles-basic-color.png",
43144314
"excludeFromAutomaticTesting": true,
4315-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4315+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
43164316
},
43174317
{
43184318
"title": "Particles - Basic Properties - Speed",
@@ -4344,7 +4344,7 @@
43444344
"renderCount": 120,
43454345
"referenceImage": "particles-basic-direction.png",
43464346
"excludeFromAutomaticTesting": true,
4347-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4347+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
43484348
},
43494349
{
43504350
"title": "Particles - Basic Properties - Direction - Gravity",
@@ -4364,7 +4364,7 @@
43644364
"renderCount": 120,
43654365
"referenceImage": "particles-basic-emit-rate-fast.png",
43664366
"excludeFromAutomaticTesting": true,
4367-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4367+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
43684368
},
43694369
{
43704370
"title": "Particles - Basic Properties - Emission Limits",
@@ -4390,7 +4390,7 @@
43904390
"renderCount": 120,
43914391
"referenceImage": "particles-basic-change-size.png",
43924392
"excludeFromAutomaticTesting": true,
4393-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4393+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
43944394
},
43954395
{
43964396
"title": "Particles - Change - Size 2",
@@ -4404,15 +4404,15 @@
44044404
"renderCount": 120,
44054405
"referenceImage": "particles-basic-change-color.png",
44064406
"excludeFromAutomaticTesting": true,
4407-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4407+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
44084408
},
44094409
{
44104410
"title": "Particles - Change - Color 2",
44114411
"playgroundId": "#0K3AQ2#3851",
44124412
"renderCount": 120,
44134413
"referenceImage": "particles-basic-change-color-2.png",
44144414
"excludeFromAutomaticTesting": true,
4415-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4415+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
44164416
},
44174417
{
44184418
"title": "Particles - Change - Speed",
@@ -4474,7 +4474,7 @@
44744474
"renderCount": 120,
44754475
"referenceImage": "particles-basic-change-lifetime.png",
44764476
"excludeFromAutomaticTesting": true,
4477-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4477+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
44784478
},
44794479
{
44804480
"title": "Particles - Change - Lifetime 2",
@@ -4494,23 +4494,23 @@
44944494
"renderCount": 120,
44954495
"referenceImage": "particles-emitters-point.png",
44964496
"excludeFromAutomaticTesting": true,
4497-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4497+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
44984498
},
44994499
{
45004500
"title": "Particles - Emitters - Box",
45014501
"playgroundId": "#WLX2I2#8",
45024502
"renderCount": 120,
45034503
"referenceImage": "particles-emitters-box.png",
45044504
"excludeFromAutomaticTesting": true,
4505-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4505+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
45064506
},
45074507
{
45084508
"title": "Particles - Emitters - Sphere",
45094509
"playgroundId": "#WLX2I2#9",
45104510
"renderCount": 120,
45114511
"referenceImage": "particles-emitters-sphere.png",
45124512
"excludeFromAutomaticTesting": true,
4513-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4513+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
45144514
},
45154515
{
45164516
"title": "Particles - Emitters - Directed Sphere",
@@ -4530,7 +4530,7 @@
45304530
"renderCount": 120,
45314531
"referenceImage": "particles-emitters-cylinder.png",
45324532
"excludeFromAutomaticTesting": true,
4533-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4533+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
45344534
},
45354535
{
45364536
"title": "Particles - Emitters - Directed Cylinder",
@@ -4552,7 +4552,7 @@
45524552
"renderCount": 120,
45534553
"referenceImage": "particles-emitters-directed-cone.png",
45544554
"excludeFromAutomaticTesting": true,
4555-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4555+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
45564556
},
45574557
{
45584558
"title": "Particles - Emitters - Mesh",
@@ -4610,7 +4610,7 @@
46104610
"renderCount": 120,
46114611
"referenceImage": "particles-billboard-false.png",
46124612
"excludeFromAutomaticTesting": true,
4613-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4613+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
46144614
},
46154615
{
46164616
"title": "Particles - Multiply Blend",
@@ -4640,7 +4640,7 @@
46404640
"renderCount": 120,
46414641
"referenceImage": "particles-helper-sun.png",
46424642
"excludeFromAutomaticTesting": true,
4643-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up."
4643+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up."
46444644
},
46454645
{
46464646
"title": "Particles - Helper - Smoke",
@@ -4663,7 +4663,7 @@
46634663
"playgroundId": "#DEZ79M#73",
46644664
"renderCount": 240,
46654665
"excludeFromAutomaticTesting": true,
4666-
"reason": "Pixel diff after #1569 instance-data stride fix; not stride-related, needs follow-up.",
4666+
"reason": "Pixel diff after #1691 instance-data stride fix; not stride-related, needs follow-up.",
46674667
"referenceImage": "particles-attractors.png"
46684668
},
46694669
{

0 commit comments

Comments
 (0)