Use short-array syntax for lists

Author: bkdotcom

src/HttpFactory/Factory.php

@@ -134,7 +134,7 @@ public function createStreamFromFile(string $filename, string $mode = 'r'): Stre
         $resource = \fopen($filename, $mode);
         \restore_error_handler();
         if ($resource === false) {
-            if ($mode === '' || \in_array($mode[0], array('r', 'w', 'a', 'x', 'c'), true) === false) {
+            if ($mode === '' || \in_array($mode[0], ['r', 'w', 'a', 'x', 'c'], true) === false) {
                 throw new InvalidArgumentException('The mode "' . $mode . '" is invalid.');
             }
             throw new RuntimeException(\sprintf(

src/HttpMessage/AbstractUri.php

@@ -59,7 +59,7 @@ abstract class AbstractUri
     protected function assertHost($host): void
     {
         $this->assertString($host, 'host');
-        if (\in_array($host, array('', 'localhost'), true)) {
+        if (\in_array($host, ['', 'localhost'], true)) {
             // An empty host value is equivalent to removing the host.
             // No validation required
             return;

src/HttpMessage/AssertionTrait.php

@@ -27,15 +27,15 @@ trait AssertionTrait
      *
      * @var numeric-string[]
      */
-    protected $validProtocolVers = array(
+    protected $validProtocolVers = [
         '0.9',
         '1.0',
         '1.1',
         '2',
         '2.0',
         '3',
         '3.0',
-    );
+    ];
 
     /**
      * Test that value is a string (or optionally numeric)
@@ -130,7 +130,7 @@ private function assertHeaderName($name): void
     private function assertHeaderValue($value): void
     {
         if (\is_scalar($value) && \is_bool($value) === false) {
-            $value = array((string) $value);
+            $value = [(string) $value];
         }
         if (\is_array($value) === false) {
             throw new InvalidArgumentException(\sprintf(
@@ -447,7 +447,7 @@ protected function assertStatusCode($code): void
      */
     private function iteratorPath(RecursiveIteratorIterator $iterator): string
     {
-        $path = array();
+        $path = [];
         for ($i = 0, $depth = $iterator->getDepth(); $i <= $depth; $i++) {
             $key = $iterator->getSubIterator($i)->key();
             $path[] = $i > 0

src/HttpMessage/Message.php

@@ -127,7 +127,7 @@ public function getHeader(string $name): array
     {
         $nameLower = \strtolower($name);
         if (!isset($this->headerNames[$nameLower])) {
-            return array();
+            return [];
         }
         $name = $this->headerNames[$nameLower];
         return $this->headers[$name];

src/HttpMessage/Response.php

@@ -130,6 +130,6 @@ private function filterCodePhrase($code, $phrase)
             $phrase = ResponseUtil::codePhrase($code);
         }
         $this->assertReasonPhrase($phrase);
-        return array($code, $phrase);
+        return [$code, $phrase];
     }
 }

src/HttpMessage/ServerRequest.php

@@ -127,8 +127,8 @@ public function __construct(string $method = 'GET', $uri = '', array $serverPara
                 ? $parsed
                 : null;
         });
-        $this->registerMediaTypeParser(ContentType::XML_APP, array(__CLASS__, 'parseXml'));
-        $this->registerMediaTypeParser(ContentType::XML, array(__CLASS__, 'parseXml'));
+        $this->registerMediaTypeParser(ContentType::XML_APP, [__CLASS__, 'parseXml']);
+        $this->registerMediaTypeParser(ContentType::XML, [__CLASS__, 'parseXml']);
     }
 
     /**

src/HttpMessage/ServerRequestExtended.php

@@ -87,7 +87,7 @@ public function getMediaTypeParams(): array
             'charset' => null,
         );
 
-        if ($contentType === array()) {
+        if ($contentType === []) {
             return $params;
         }
 

src/HttpMessage/Utility/ServerRequest.php

@@ -77,7 +77,7 @@ public static function fromGlobals($parseStrOpts = array()): ServerRequestExtend
      *
      * @throws InvalidArgumentException
      */
-    private static function filesFromGlobals(array $phpFiles, array $path = array()): array
+    private static function filesFromGlobals(array $phpFiles, array $path = []): array
     {
         $files = array();
         /** @var mixed $value */
@@ -179,15 +179,15 @@ private static function fileFromGlobalCreate(array $fileInfo)
      */
     private static function isUploadFileInfoArray(array $array): bool
     {
-        $keysMustHave = array('name', 'type', 'tmp_name', 'size', 'error');
-        $keysMayHave = array('full_path');
+        $keysMustHave = ['name', 'type', 'tmp_name', 'size', 'error'];
+        $keysMayHave = ['full_path'];
         $keys = \array_keys($array);
         if (\array_intersect($keysMustHave, $keys) !== $keysMustHave) {
             // missing must have
             return false;
         }
         // return true if no unknown keys
-        return \array_diff($keys, \array_merge($keysMustHave, $keysMayHave)) === array();
+        return \array_diff($keys, \array_merge($keysMustHave, $keysMayHave)) === [];
     }
 
     /**

src/HttpMessage/Utility/Uri.php

@@ -62,13 +62,13 @@ public static function fromParsed(array $parsed): BdkUri
         $uriKeys = ['fragment', 'host', 'path', 'port', 'query', 'scheme', 'userInfo'];
         $parsed = \array_intersect_key(self::parsedPartsPrep($parsed), \array_flip($uriKeys));
         $parsed = \array_filter($parsed, static function ($val) {
-            return \in_array($val, array(null, ''), true) === false;
+            return \in_array($val, [null, ''], true) === false;
         });
         $uri = new BdkUri();
         foreach ($parsed as $key => $value) {
             $method = 'with' . \ucfirst($key);
             /** @var BdkUri */
-            $uri = \call_user_func_array(array($uri, $method), (array) $value);
+            $uri = \call_user_func_array([uri, $method], (array) $value);
         }
         return $uri;
     }
@@ -199,7 +199,7 @@ private static function parsedPartsPrep(array $parsed): array
             'user' => '',
         ), $renamed, $parsed);
         if (\array_key_exists('userInfo', $parsed) === false) {
-            $parsed['userInfo'] = array($parsed['user'], $parsed['pass']);
+            $parsed['userInfo'] = [$parsed['user'], $parsed['pass']];
         }
         if (\is_array($parsed['userInfo']) === false) {
             $parsed['userInfo'] = \explode(':', (string) $parsed['userInfo'], 2);
@@ -282,7 +282,7 @@ private static function pathRemoveDots(string $path): string
         if ($path[0] === '/' && (!isset($pathNew[0]) || $pathNew[0] !== '/')) {
             // Re-add the leading slash if necessary for cases like "/.."
             $pathNew = '/' . $pathNew;
-        } elseif ($pathNew !== '' && \in_array(\end($segments), array('.', '..'), true)) {
+        } elseif ($pathNew !== '' && \in_array(\end($segments), ['.', '..'], true)) {
             // Add the trailing slash if necessary
             $pathNew .= '/';
         }
@@ -342,7 +342,7 @@ private static function resolveTargetPath(UriInterface $base, UriInterface $rel)
      */
     private static function uriInterfaceToParts(UriInterface $url): array
     {
-        $userInfo = \array_replace(array(null, null), \explode(':', $url->getUserInfo(), 2));
+        $userInfo = \array_replace([null, null], \explode(':', $url->getUserInfo(), 2));
         $parts = array(
             'pass' => $userInfo[1],
             'user' => $userInfo[0],