Update comments

Author: bkdotcom

src/Container/ObjectBuilder.php

@@ -70,16 +70,17 @@ public function __construct(Container $container)
      *
      * We will look for the class in the container
      * If it is not found, we will try to instantiate it via reflection and obtaining dependencies via the container
-     * We will save the instance in the container
      *
-     * @param string $classname    Fully qualified class name
-     * @param bool   $useContainer (true) Pull obj from container if available / store obj in container after build
+     * if $save is true, we will save the instance in the container
+     *
+     * @param string $classname Fully qualified class name
+     * @param bool   $save      (true) store built object in container after build
      *
      * @return object
      *
      * @throws RuntimeException
      */
-    public function build($classname, $useContainer = true)
+    public function build($classname, $save = true)
     {
         if ($this->container->has($classname)) {
             return $this->container->get($classname);
@@ -90,7 +91,7 @@ public function build($classname, $useContainer = true)
             ? $this->resolveConstructorArgs($refConstructor)
             : [];
         $return = $refClass->newInstanceArgs($paramValues);
-        if ($useContainer) {
+        if ($save) {
             $this->container->offsetSet($classname, $return);
         }
         return $return;

src/PubSub/ValueStore.php

@@ -24,6 +24,8 @@
  * Note:
  *   - The Serializable interface - since PHP 5.1.  Deprecated in php 8.1
  *   - __serialize and __unserialize magic methods : since PHP 7.4
+ *   - if __serialize is present, it will be used instead of Serializable::serialize
+ *   -   objects serialized with __serialize can not be unserialized
  *
  * @template TKey   of array-key
  * @template TValue of mixed

tests/Debug/Utility/SerializeLogTest.php

@@ -86,6 +86,8 @@ public static function importProvider()
             );
         }
         if (PHP_VERSION_ID < 70400) {
+            // objects serialized with __serialize can not be unserialized in php < 7.4
+            //  v2.3 did not use __serialize, so can still test that
             return \array_intersect_key($tests, \array_flip(['2.3']));
         }