Fix UB in priority_queue_pop#156
Open
Unknown-reader wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an undefined behavior in the
priority_queue_popfunction caused bymemcpybeing called with overlapping memory regions. This occurs when the priority queue contains exactly one element.Problem
In
src/priority_queue.c, line 170,memcpyis used to copy the last element to the root of the heap:When the queue contains only one element (
size == 0), bothtempandvector_storagepoint to the same memory address, resulting in amemcpycall with identicalsrcanddestpointers. This is undefined behavior according to the C standard.Fix
Replaced the unsafe
memcpyon line 170 withmemmove, which is specifically designed to handle overlapping memory regions correctly. No other changes were necessary, as the othermemcpycalls in the function operate on non-overlapping memory regions.