widgets: Fix some issues (#1900)

* widgets: correct OH_Partner_frame.png dimensions, metadata, and test fixtures

OH_Partner_frame.png had a 1px transparent row at y=0, so all visible
content started at y=1. This caused the rendered Detailed widget to
appear shifted down with an empty row at the top and the bottom pixel
clipped off.

The Detailed widget model also reported width: 230 but the frame image
is 232px wide, causing the HTML embed <img width="230"> to clip 2px off
the right edge.

Test fixtures regenerated to match the corrected frame.

* widgets: correct Tiny widget height to match profile_tiny.png (15 → 16)

profile_tiny.png is 80×16 but the Tiny widget model reported height: 15,
causing the HTML embed <img height="15"> to scale the image down by 1px
vertically.

* widgets: add PNG output format support

Widget image generation produces PNG internally — the pipeline opens
OH_Partner_frame.png, composites text and kudos onto it, and returns the
result via MiniMagick's to_blob, which emits PNG bytes. Previously those
bytes were served as image/gif regardless of what was requested, which
is a lie about the Content-Type.

Add proper ?format=png support by renaming render_image_for_gif_format
to render_image_for_image_format (and the "not supported" equivalent)
across all five widget controllers. PNG requests now receive
Content-Type: image/png with the same underlying bytes — no conversion
needed since the data is already PNG. GIF requests preserve existing
behavior for backward compatibility.

* widgets: flatten transparent background to white

OH_Partner_frame.png has an alpha channel — the right-side content area
where name, commits, and kudos are composited was transparent rather
than opaque white. The kudos laurel badge composited on top has a white
background, making the two visually inconsistent: the laurel shows white
while surrounding areas are transparent, appearing as a checkerboard in
image viewers or taking on the page background color in browsers.

Add image.flatten to setup_blank in badge_helper.rb. flatten fills
transparent pixels with the current background color, which is already
set to white on the line above, producing a fully opaque image before
any compositing begins. setup_blank is shared by all three badge types
(Account, Partner, Thin), so all affected test fixtures are regenerated.

* positions: use must_include instead of must_match for org name

Faker-generated org names with special characters (e.g. apostrophes)
create broken regexes when passed as strings to must_match. Use
must_include instead, which does plain substring matching.

Author: mattst88

app/assets/images/widget_logos/OH_Partner_frame.png

@@ -2,7 +2,7 @@
 
 class AccountWidgetsController < WidgetsController
   before_action :set_account
-  before_action :render_image_for_gif_format
+  before_action :render_image_for_image_format
   before_action :account_context, only: :index
 
   def index

app/controllers/account_widgets_controller.rb

@@ -2,7 +2,7 @@
 
 class OrganizationWidgetsController < WidgetsController
   before_action :set_organization
-  before_action :render_not_supported_for_gif_format
+  before_action :render_not_supported_for_image_format
   before_action :render_iframe_for_js_format
   before_action :organization_context, only: :index
 

app/controllers/organization_widgets_controller.rb

@@ -3,8 +3,8 @@
 class ProjectWidgetsController < WidgetsController
   helper :Projects, :Analyses
   before_action :set_project
-  before_action :render_image_for_gif_format, only: %i[partner_badge thin_badge]
-  before_action :render_not_supported_for_gif_format, except: %i[partner_badge thin_badge index]
+  before_action :render_image_for_image_format, only: %i[partner_badge thin_badge]
+  before_action :render_not_supported_for_image_format, except: %i[partner_badge thin_badge index]
   before_action :render_iframe_for_js_format
   before_action :project_context, only: :index
 

app/controllers/project_widgets_controller.rb

@@ -3,7 +3,7 @@
 class StackWidgetsController < WidgetsController
   before_action :set_widget
   before_action :set_stack_and_account
-  before_action :render_not_supported_for_gif_format
+  before_action :render_not_supported_for_image_format
   before_action :render_iframe_for_js_format
   before_action :account_context, only: :index
 

app/controllers/stack_widgets_controller.rb

@@ -27,19 +27,30 @@ def set_widget
                     .new(permitted_params)
   end
 
-  def render_image_for_gif_format
-    return unless request.format.gif?
+  def render_image_for_image_format
+    return unless request.format.gif? || request.format.png?
 
+    send_data(cached_widget_image, disposition: 'inline', type: image_mime_type, filename: image_filename, status: 200)
+  end
+
+  def cached_widget_image
     cache_key = "#{@widget.parent.class.name}/#{@widget.parent.id}/#{@widget.name}"
-    image = Rails.cache.fetch(cache_key, expires_in: 4.hours) { @widget.image }
-    send_data(image, disposition: 'inline', type: 'image/gif', filename: 'widget.gif', status: 200)
+    Rails.cache.fetch(cache_key, expires_in: 4.hours) { @widget.image }
   end
 
-  def render_not_supported_for_gif_format
-    return unless request.format.gif?
+  def render_not_supported_for_image_format
+    return unless request.format.gif? || request.format.png?
 
     image = Rails.cache.fetch('not_supported_widget') { WidgetBadge::Thin.create([text: 'Not supported']) }
-    send_data(image, disposition: 'inline', type: 'image/gif', filename: 'widget.gif', status: 406)
+    send_data(image, disposition: 'inline', type: image_mime_type, filename: image_filename, status: 406)
+  end
+
+  def image_mime_type
+    request.format.png? ? 'image/png' : 'image/gif'
+  end
+
+  def image_filename
+    request.format.png? ? 'widget.png' : 'widget.gif'
   end
 
   def render_iframe_for_js_format

app/controllers/widgets_controller.rb

@@ -2,7 +2,7 @@
 
 class Widget::AccountWidget::Detailed < Widget::AccountWidget
   def width
-    230
+    232
   end
 
   def height

app/models/widget/account_widget/detailed.rb

@@ -2,7 +2,7 @@
 
 class Widget::AccountWidget::Tiny < Widget::AccountWidget
   def height
-    15
+    16
   end
 
   def width

app/models/widget/account_widget/tiny.rb

@@ -15,6 +15,7 @@ module ClassMethods
       def setup_blank
         image = MiniMagick::Image.open(IMAGE_DIR.join('OH_Partner_frame.png'))
         image.background('white')
+        image.flatten
         image
       end
 

lib/widget_badge/badge_helper.rb

@@ -332,7 +332,7 @@ class PositionsControllerTest < ActionController::TestCase
       assert_response :success
       language = position.name_fact.primary_language.nice_name
       _(unescaped_response_body).must_match "1\nCommit\n</a>in mostly\n#{language}"
-      _(unescaped_response_body).must_match position.name_fact.analysis.project.organization.name
+      _(unescaped_response_body).must_include position.name_fact.analysis.project.organization.name
       assert_select 'div#all_projects.chart-with-data[data-value]', 1
     end