OTWO-7640 Ignore-files ui silently discards input exceeding 1000 chars (#1896)

* OTWO-7640 Ignore-files ui silently discards input exceeding 1000 chars

* Rubocop and code review fix

* Testcase coverage

* solved allowed files update issue

Author: Niharika1117

app/controllers/enlistments_controller.rb

@@ -47,9 +47,13 @@ def edit_allowed_files
   end
 
   def update
-    @enlistment.update(enlistment_params)
-    @enlistment.project.schedule_delayed_analysis(3.minutes)
-    redirect_to project_enlistments_path(@project), flash: { success: t('.success') }
+    if @enlistment.update(enlistment_params)
+      @enlistment.project.schedule_delayed_analysis(3.minutes)
+      redirect_to project_enlistments_path(@project), flash: { success: t('.success') }
+    else
+      template = params[:enlistment].key?(:allowed_fyles) ? :edit_allowed_files : :edit
+      render template, status: :unprocessable_entity
+    end
   end
 
   def destroy

app/models/enlistment.rb

@@ -19,7 +19,7 @@ class Enlistment < ApplicationRecord
   acts_as_editable editable_attributes: [:ignore]
   acts_as_protected parent: :project
 
-  validates :ignore, length: { maximum: 1000 }, allow_nil: true
+  validates :ignore, length: { maximum: 1000, message: :too_long_ignore }, allow_nil: true
   validates :allowed_fyles, length: { maximum: 1000 }, allow_nil: true
   validate :validate_code_location, if: -> { @nested_code_location }
 

config/locales/enlistments.en.yml

@@ -1,4 +1,11 @@
 en:
+  activerecord:
+    errors:
+      models:
+        enlistment:
+          attributes:
+            ignore:
+              too_long_ignore: 'cannot exceed 1000 characters'
   enlistments:
     index:
       title: 'The %{name} Open Source Project on Open Hub : Code Locations Page'

test/controllers/commits_controller_test.rb

@@ -198,6 +198,38 @@ class CommitsControllerTest < ActionController::TestCase
     end
   end
 
+  describe 'individual_named_commits' do
+    it 'should set commits to empty array when commit_contributor is nil' do
+      Project.any_instance.stubs(:commit_contributors).returns(stub(find_by: nil))
+      get :index, params: { project_id: @project.id, contributor_id: 0 }
+      _(assigns(:commits)).must_equal []
+    end
+  end
+
+  describe 'events and event_details with no analysis' do
+    it 'should return not_found xml when project has no analysis for events' do
+      Project.any_instance.stubs(:best_analysis).returns(NilAnalysis.new)
+      get :events, params: { project_id: @project.id, id: @commit1.id, contributor_id: @name1.id }, format: :xml
+      assert_response :not_found
+    end
+
+    it 'should render 404 when contributor fact not found for event_details' do
+      ContributorFact.stubs(:find_by).returns(nil)
+      Airbrake.stubs(:notify)
+      get :event_details, params: { contributor_id: 0, id: @commit1.id,
+                                    project_id: @project.id, time: "commit_#{@commit1.time.to_i}" }
+      assert_response :not_found
+    end
+  end
+
+  describe 'redirect_to_message_if_oversized_project' do
+    it 'should redirect to root when project is oversized' do
+      CommitsController.any_instance.stubs(:oversized_project?).returns(true)
+      get :index, params: { project_id: @project.id }
+      assert_redirected_to root_path
+    end
+  end
+
   private
 
   def create_commits

test/models/enlistment_test.rb

@@ -89,6 +89,40 @@ class EnlistmentTest < ActiveSupport::TestCase
     end
     _(KnowledgeBaseStatus.find_by(project_id: enlistment.project_id).in_sync).must_equal false
   end
+
+  describe 'ignore field validation' do
+    it 'should allow nil value' do
+      enlistment = create(:enlistment, ignore: nil)
+      _(enlistment.valid?).must_equal true
+    end
+
+    it 'should allow empty string' do
+      enlistment = create(:enlistment, ignore: '')
+      _(enlistment.valid?).must_equal true
+    end
+
+    it 'should allow strings under 1000 characters' do
+      enlistment = create(:enlistment, ignore: 'a' * 500)
+      _(enlistment.valid?).must_equal true
+    end
+
+    it 'should allow strings exactly 1000 characters' do
+      enlistment = create(:enlistment, ignore: 'a' * 1000)
+      _(enlistment.valid?).must_equal true
+    end
+
+    it 'should reject strings exceeding 1000 characters with appropriate error messages' do
+      enlistment = build(:enlistment, ignore: 'a' * 1001)
+      _(enlistment.valid?).must_equal false
+      _(enlistment.errors[:ignore]).must_include 'cannot exceed 1000 characters'
+      _(enlistment.errors.full_messages).must_include 'Ignore cannot exceed 1000 characters'
+    end
+
+    it 'should reject very long strings' do
+      enlistment = build(:enlistment, ignore: 'a' * 5000)
+      _(enlistment.valid?).must_equal false
+    end
+  end
 end
 
 # TODO: Replace this once we remove code_locations table dependency from enlistments_controller.