OTWO-7640 Ignore-files ui silently discards input exceeding 1000 chars#1896
Open
Niharika1117 wants to merge 4 commits into
Open
OTWO-7640 Ignore-files ui silently discards input exceeding 1000 chars#1896Niharika1117 wants to merge 4 commits into
Niharika1117 wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses the “ignore-files” UI issue where input exceeding 1000 characters was silently discarded, by surfacing validation errors instead of always redirecting after update.
Changes:
- Adds/updates model validation messaging for
Enlistment#ignorelength (max 1000 chars). - Updates
EnlistmentsController#updateto render the edit form on validation failure instead of always redirecting. - Adds model tests covering
ignorelength boundary behavior and expected error messaging.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| app/controllers/enlistments_controller.rb | Render edit view on failed update to preserve input and show validation errors. |
| app/models/enlistment.rb | Customizes ignore length validation message at 1000 characters. |
| test/models/enlistment_test.rb | Adds specs for ignore validation boundary conditions and error message expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+55
| if @enlistment.update(enlistment_params) | ||
| @enlistment.project.schedule_delayed_analysis(3.minutes) | ||
| redirect_to project_enlistments_path(@project), flash: { success: t('.success') } | ||
| else | ||
| render :edit, status: :unprocessable_entity | ||
| end |
Priya5
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.