Skip to content

Add option to disable negative signatures#891

Merged
liquidsec merged 1 commit into
devfrom
disable-negative-signatures
May 25, 2026
Merged

Add option to disable negative signatures#891
liquidsec merged 1 commit into
devfrom
disable-negative-signatures

Conversation

@liquidsec

Copy link
Copy Markdown
Collaborator

Summary

  • Adds --disable-negative-signatures CLI flag and matching disable_negative_signatures kwarg on BadDNS_base so callers (CLI, BBOT) can opt out of negative-signature suppression in the CNAME and NS modules. When set, generic dangling CNAME/NS findings fire even for known non-exploitable services (Cloudflare, Akamai, etc).
  • Fixes a latent test regression from commit 137561f: under pyfakefs, tldextract's suffix-list fetch raised OSError (certifi cacert hidden) which it doesn't catch, so the snapshot fallback never ran. An autouse conftest fixture now exposes the real cacert to the fake fs so the fetch fails as a RequestException and tldextract uses its bundled snapshot.

…s still fire for known non-exploitable services
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (96ed35e) to head (0ba6c0b).

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #891   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines         1924      1927    +3     
=========================================
+ Hits          1924      1927    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liquidsec

Copy link
Copy Markdown
Collaborator Author

@SpamFaux as requested. Will ship in 2.4

@liquidsec liquidsec merged commit 0bef233 into dev May 25, 2026
10 checks passed
@liquidsec liquidsec mentioned this pull request May 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants