Add option to disable negative signatures#891
Merged
Conversation
…s still fire for known non-exploitable services
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #891 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1924 1927 +3
=========================================
+ Hits 1924 1927 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@SpamFaux as requested. Will ship in 2.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--disable-negative-signaturesCLI flag and matchingdisable_negative_signatureskwarg onBadDNS_baseso callers (CLI, BBOT) can opt out of negative-signature suppression in the CNAME and NS modules. When set, generic dangling CNAME/NS findings fire even for known non-exploitable services (Cloudflare, Akamai, etc).tldextract's suffix-list fetch raisedOSError(certifi cacert hidden) which it doesn't catch, so the snapshot fallback never ran. An autouse conftest fixture now exposes the real cacert to the fake fs so the fetch fails as aRequestExceptionand tldextract uses its bundled snapshot.